[GitHub] [airflow] josh-fell commented on a diff in pull request #29840: DatabricksSubmitRunOperator to support taskflow

["josh-fell (via GitHub)" <gi...@apache.org>]

josh-fell commented on code in PR #29840:
URL: https://github.com/apache/airflow/pull/29840#discussion_r1122539049


##########
airflow/providers/databricks/operators/databricks.py:
##########
@@ -285,12 +285,12 @@ def __init__(
         *,
         json: Any | None = None,
         tasks: list[object] | None = None,
-        spark_jar_task: dict[str, str] | None = None,
-        notebook_task: dict[str, str] | None = None,
-        spark_python_task: dict[str, str | list[str]] | None = None,
-        spark_submit_task: dict[str, list[str]] | None = None,
-        pipeline_task: dict[str, str] | None = None,
-        dbt_task: dict[str, str | list[str]] | None = None,

Review Comment:
   The current typing is sufficient IMO. These args would eventually be of these types either from XComs, templates, etc.;`dict[str, object]` is nebulous.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org