You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2023/01/15 13:36:45 UTC
[GitHub] [incubator-pekko-connectors-kafka] mdedetrich opened a new issue, #14: Revert removal of return function type in `streamProbesWithOffsetFactory` when new scalafmt version is out
mdedetrich opened a new issue, #14:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/issues/14
In https://github.com/apache/incubator-pekko-connectors-kafka/pull/8 we removed the return function type because scalafmt has a bug with tuples as return function types in order to unblock the repo.
When a new version of scalafmt is out we should revert the change, just to be on the safe side to ensure that no important code has been changed from Akka latest Apache release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning closed issue #14: Revert removal of return function type in `streamProbesWithOffsetFactory` when new scalafmt version is out
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed issue #14: Revert removal of return function type in `streamProbesWithOffsetFactory` when new scalafmt version is out
URL: https://github.com/apache/incubator-pekko-connectors-kafka/issues/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] seglo commented on issue #14: Revert removal of return function type in `streamProbesWithOffsetFactory` when new scalafmt version is out
Posted by GitBox <gi...@apache.org>.
seglo commented on issue #14:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/issues/14#issuecomment-1383361024
In this case it's just a private test method so any risk is pretty minimal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] mdedetrich commented on issue #14: Revert removal of return function type in `streamProbesWithOffsetFactory` when new scalafmt version is out
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on issue #14:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/issues/14#issuecomment-1383579846
Agreed, this is more about confidence wrt "the initial 1.0.x release has the same code as latest Akka BSL" even if its largely technically superficial with this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org