You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@polaris.apache.org by yz...@apache.org on 2026/10/27 14:06:13 UTC
(polaris) branch main updated: Fix Helm chart management Service ignoring managementService.labels (#5878)
This is an automated email from the ASF dual-hosted git repository.
MonkeyCanCode pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git
The following commit(s) were added to refs/heads/main by this push:
new f2a2b4da6a Fix Helm chart management Service ignoring managementService.labels (#5878)
f2a2b4da6a is described below
commit f2a2b4da6a5385fd382e6e7318e3d0f307c35cfa
Author: Sang Hyun Lee <sh...@gmail.com>
AuthorDate: Tue Oct 27 23:06:05 2026 +0900
Fix Helm chart management Service ignoring managementService.labels (#5878)
---
helm/polaris/templates/service-mgmt.yaml | 2 +-
helm/polaris/tests/service_mgmt_test.yaml | 9 ++++++++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/helm/polaris/templates/service-mgmt.yaml b/helm/polaris/templates/service-mgmt.yaml
index f387802b50..5b295cd617 100644
--- a/helm/polaris/templates/service-mgmt.yaml
+++ b/helm/polaris/templates/service-mgmt.yaml
@@ -24,7 +24,7 @@ metadata:
namespace: {{ .Release.Namespace }}
labels:
{{- include "polaris.labels" . | nindent 4 }}
- {{- with .Values.service.labels }}
+ {{- with .Values.managementService.labels }}
{{- toYaml . | nindent 4 }}
{{- end }}
{{- with .Values.managementService.annotations }}
diff --git a/helm/polaris/tests/service_mgmt_test.yaml b/helm/polaris/tests/service_mgmt_test.yaml
index 61860d809a..92a17a3219 100644
--- a/helm/polaris/tests/service_mgmt_test.yaml
+++ b/helm/polaris/tests/service_mgmt_test.yaml
@@ -70,13 +70,20 @@ tests:
helm.sh/chart: polaris-1.2.3
- it: should set service custom labels
set:
- service.labels:
+ managementService.labels:
foo: bar
asserts:
- isSubset:
path: metadata.labels
content:
foo: bar
+ - it: should not set main service custom labels
+ set:
+ service.labels:
+ foo: bar
+ asserts:
+ - notExists:
+ path: metadata.labels.foo
# metadata.annotations
- it: should not set service annotations by default