You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by anmolnar <gi...@git.apache.org> on 2018/05/18 00:12:08 UTC

[GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...

Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r189135140
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
    @@ -254,6 +260,9 @@ protected void connectToLeader(InetSocketAddress addr)
                     }
     
                     sockConnect(sock, addr, Math.min(self.tickTime * self.syncLimit, remainingInitLimitTime));
    +                if (self.isSslQuorum())  {
    +                    ((SSLSocket) sock).startHandshake();
    +                }
                     sock.setTcpNoDelay(nodelay);
                     break;
                 } catch (IOException e) {
    --- End diff --
    
    Setting the following system property will give you very detailed SSL logging:
    `-Djavax.net.debug=ssl:all`
    I'll add it to the documentation.


---