[jira] [Updated] (TAP5-1901) Plastic creates field access methods for some injected fields unnecessarily

["Jochen Kemnade (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TAP5-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jochen Kemnade updated TAP5-1901:
---------------------------------

    Issue Type: Improvement  (was: Bug)

> Plastic creates field access methods for some injected fields unnecessarily
> ---------------------------------------------------------------------------
>
>                 Key: TAP5-1901
>                 URL: https://issues.apache.org/jira/browse/TAP5-1901
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: plastic
>    Affects Versions: 5.3.3, 5.4
>            Reporter: Howard M. Lewis Ship
>            Priority: Minor
>
> While looking into another problem, noticed the following:
>       final reject_field_change_internalComponentResources(Lorg/apache/tapestry5/internal/InternalComponentResources;)V
>         NEW java/lang/IllegalStateException
>         DUP
>         LDC "Field internalComponentResources of class test.base.pages.Grandparent is read-only."
>         INVOKESPECIAL java/lang/IllegalStateException.<init> (Ljava/lang/String;)V
>         ATHROW
>         MAXSTACK = 0
>         MAXLOCALS = 0
> Plastic should not be creating such methods for injected fields; those fields are not visible to (untransformed) subclasses (they don't exist until after transformation). These kinds of methods exist for incorrect user code that (in untransformed classes) illegally assigns to a field that is read-only in the transformed class.



--
This message was sent by Atlassian JIRA
(v6.2#6252)