You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Donny9 (via GitHub)" <gi...@apache.org> on 2024/09/08 15:08:04 UTC
[PR] sched/group/setuptask_file: duplicate idle task fd for kernel thread [nuttx]
Donny9 opened a new pull request, #13329:
URL: https://github.com/apache/nuttx/pull/13329
## Summary
sched/group/setuptask_file: duplicate idle task fd for kernel thread.
The file descriptors of kernel threads should be clean and should not be generated based on user threads. Instead, an idle thread hould be chosen.
## Impact
Clean the file descriptors of kernel threads
## Testing
Vela
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sched/group/setuptask_file: duplicate idle task fd for kernel thread [nuttx]
Posted by "Donny9 (via GitHub)" <gi...@apache.org>.
Donny9 commented on code in PR #13329:
URL: https://github.com/apache/nuttx/pull/13329#discussion_r1749274666
##########
sched/group/group_setuptaskfiles.c:
##########
@@ -75,7 +75,20 @@ int group_setuptaskfiles(FAR struct task_tcb_s *tcb,
#endif
#ifndef CONFIG_FDCLONE_DISABLE
- DEBUGASSERT(rtcb->group);
+
+ /* the The file descriptors of kernel threads should be clean and
Review Comment:
Done~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sched/group/setuptask_file: duplicate idle task fd for kernel thread [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #13329:
URL: https://github.com/apache/nuttx/pull/13329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] sched/group/setuptask_file: duplicate idle task fd for kernel thread [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #13329:
URL: https://github.com/apache/nuttx/pull/13329#discussion_r1749273703
##########
sched/group/group_setuptaskfiles.c:
##########
@@ -75,7 +75,20 @@ int group_setuptaskfiles(FAR struct task_tcb_s *tcb,
#endif
#ifndef CONFIG_FDCLONE_DISABLE
- DEBUGASSERT(rtcb->group);
+
+ /* the The file descriptors of kernel threads should be clean and
Review Comment:
```suggestion
/* The file descriptors of kernel threads should be clean and
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org