You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by ok...@apache.org on 2016/10/12 21:24:59 UTC

tinkerpop git commit: realized a bug in Gremlin-Python around withComputer() during manual playing/testing. We didn't have a test case for the situation. Fixed problem and added test case to verify proper functioning. CTR.

Repository: tinkerpop
Updated Branches:
  refs/heads/master e2131957e -> e56e97d5d


realized a bug in Gremlin-Python around withComputer() during manual playing/testing. We didn't have a test case for the situation. Fixed problem and added test case to verify proper functioning. CTR.


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/e56e97d5
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/e56e97d5
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/e56e97d5

Branch: refs/heads/master
Commit: e56e97d5de740b8afe19d5b2915888d3f643a0ef
Parents: e213195
Author: Marko A. Rodriguez <ok...@gmail.com>
Authored: Wed Oct 12 15:24:48 2016 -0600
Committer: Marko A. Rodriguez <ok...@gmail.com>
Committed: Wed Oct 12 15:24:48 2016 -0600

----------------------------------------------------------------------
 .../src/main/jython/gremlin_python/process/strategies.py     | 8 ++++----
 .../jython/tests/driver/test_driver_remote_connection.py     | 4 ++++
 2 files changed, 8 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/e56e97d5/gremlin-python/src/main/jython/gremlin_python/process/strategies.py
----------------------------------------------------------------------
diff --git a/gremlin-python/src/main/jython/gremlin_python/process/strategies.py b/gremlin-python/src/main/jython/gremlin_python/process/strategies.py
index 4d4cbda..b5ea065 100644
--- a/gremlin-python/src/main/jython/gremlin_python/process/strategies.py
+++ b/gremlin-python/src/main/jython/gremlin_python/process/strategies.py
@@ -70,11 +70,11 @@ class SubgraphStrategy(TraversalStrategy):
 
 
 class VertexProgramStrategy(TraversalStrategy):
-    def __init__(self, graph_computer=None, workers=None, persist=None, result=None, vertices=None, edges=None,
-                 configuration=None):
+    def __init__(self, graph_computer=None,
+                 workers=None, persist=None, result=None, vertices=None, edges=None, configuration=None):
         TraversalStrategy.__init__(self)
-        if graph_computer is not None:
-            self.configuration["graphComputer"] = graph_computer
+        self.configuration["graphComputer"] = \
+            graph_computer if graph_computer is not None else "org.apache.tinkerpop.gremlin.process.computer.GraphComputer"
         if workers is not None:
             self.configuration["workers"] = workers
         if persist is not None:

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/e56e97d5/gremlin-python/src/main/jython/tests/driver/test_driver_remote_connection.py
----------------------------------------------------------------------
diff --git a/gremlin-python/src/main/jython/tests/driver/test_driver_remote_connection.py b/gremlin-python/src/main/jython/tests/driver/test_driver_remote_connection.py
index 80cf0c5..6e4c0f5 100644
--- a/gremlin-python/src/main/jython/tests/driver/test_driver_remote_connection.py
+++ b/gremlin-python/src/main/jython/tests/driver/test_driver_remote_connection.py
@@ -91,6 +91,10 @@ class TestDriverRemoteConnection(TestCase):
         assert 0 == g.E().count().next()
         assert "person" == g.V().label().next()
         assert "marko" == g.V().name.next()
+
+        g = Graph().traversal().withRemote(connection).withComputer()
+        assert 6 == g.V().count().next()
+        assert 6 == g.E().count().next()
         connection.close()
 
     def test_side_effects(self):