[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1120: testing: support file system benchmark tools: iozone

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #1120:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1120#discussion_r841255892



##########
File path: testing/iozone/iozone.patch
##########
@@ -0,0 +1,54 @@
+84a85
+> #include <sys/types.h>

Review comment:
       let's generate the patch by "git format HEAD~"?

##########
File path: testing/iozone/Makefile
##########
@@ -0,0 +1,68 @@
+############################################################################
+# apps/testing/iozone/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.  The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(APPDIR)/Make.defs
+
+# Hello, World! built-in application info

Review comment:
       remove the wrong comment

##########
File path: testing/iozone/Makefile
##########
@@ -0,0 +1,68 @@
+############################################################################
+# apps/testing/iozone/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.  The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(APPDIR)/Make.defs
+
+# Hello, World! built-in application info
+
+PROGNAME  = $(CONFIG_TESTING_IOZONE_PROGNAME)
+PRIORITY  = $(CONFIG_TESTING_IOZONE_PRIORITY)
+STACKSIZE = $(CONFIG_TESTING_IOZONE_STACKSIZE)
+MODULE    = $(CONFIG_TESTING_IOZONE)
+
+CFLAGS   += -O3 -Dunix -DHAVE_ANSIC_C -DHAVE_PREAD -DNAME='"nuttx"'
+CFLAGS   += -DNO_MADVISE -DNO_FORK -D__FreeBSD__
+CFLAGS   += -Wno-unused-parameter -Wno-unused-function -Wno-shadow
+CFLAGS   += -Wno-unused-but-set-variable -Wno-strict-prototypes
+CFLAGS   += -Wno-misleading-indentation -Wno-maybe-uninitialized
+
+CFLAGS   += -DMAXBUFFERSIZE=32*1024 -DMAXSTREAMS=8 -DMAXNAMESIZE=NAME_MAX
+CFLAGS   += -DRECLEN_START=1024
+
+CSRCS     = iozone/src/current/libbif.c
+MAINSRC   = iozone/src/current/iozone.c
+
+CONFIG_TESTING_IOZONE_URL ?= "https://www.iozone.org/src/current/"
+
+IOZONE_UNPACKNAME = iozone
+IOZONE_VERSION = $(patsubst "%",%,$(strip $(CONFIG_TESTING_IOZONE_VERSION)))
+IOZONE_ZIP = iozone$(IOZONE_VERSION).tgz
+
+UNPACK ?= tar zxvf
+
+$(IOZONE_ZIP):
+	@echo "Downloading: $(IOZONE_ZIP)"
+	$(Q) curl -O -L $(CONFIG_TESTING_IOZONE_URL)/$(IOZONE_ZIP)
+
+$(IOZONE_UNPACKNAME): $(IOZONE_ZIP)
+	@echo "Unpacking: $(IOZONE_ZIP) -> $(IOZONE_UNPACKNAME)"
+	$(Q) $(UNPACK) $(IOZONE_ZIP)

Review comment:
       why not directly use tar zxvf and remove line 48?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org