You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/10/26 18:16:39 UTC
[GitHub] [openwhisk-deploy-kube] edokan opened a new pull request #650: Updated to include Windows tools
edokan opened a new pull request #650:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/650
Instead of `grep` which is not deployed with Windows by default, converted code to use built-in `find` tool.
Also added a step to reduce possible installation issues
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] edokan commented on a change in pull request #650: Updated to include Windows tools
Posted by GitBox <gi...@apache.org>.
edokan commented on a change in pull request #650:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/650#discussion_r512790775
##########
File path: docs/k8s-docker-for-windows.md
##########
@@ -77,6 +77,10 @@ nginx:
### Using helm to install OpenWhisk
+Installation expects `openwhisk` namespace to be created. To create, run
Review comment:
it is my bad. I had an old installation of helm in my path, so I used old version 3.1.2, instead of newer version that comes with kubernetes-helm (3.3.4). Do you want me to update documentation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on a change in pull request #650: Updated to include Windows tools
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on a change in pull request #650:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/650#discussion_r512208776
##########
File path: docs/k8s-docker-for-windows.md
##########
@@ -77,6 +77,10 @@ nginx:
### Using helm to install OpenWhisk
+Installation expects `openwhisk` namespace to be created. To create, run
Review comment:
What version of Helm3 does one get on Windows? If it supports `--create-namespace` then this can be rolled into the helm install command:
```
helm install owdev ./helm/openwhisk -n openwhisk -create-namespace -f mycluster.yaml
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on a change in pull request #650: Updated to include Windows tools
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on a change in pull request #650:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/650#discussion_r512718518
##########
File path: docs/k8s-docker-for-windows.md
##########
@@ -77,6 +77,10 @@ nginx:
### Using helm to install OpenWhisk
+Installation expects `openwhisk` namespace to be created. To create, run
Review comment:
ok. My recollection is that --create-namespace was added in helm 3.2. So if that's not the default in windows yet it is better to include the extra step here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] dgrove-oss merged pull request #650: Updated to include Windows tools
Posted by GitBox <gi...@apache.org>.
dgrove-oss merged pull request #650:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/650
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on a change in pull request #650: Updated to include Windows tools
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on a change in pull request #650:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/650#discussion_r512797486
##########
File path: docs/k8s-docker-for-windows.md
##########
@@ -77,6 +77,10 @@ nginx:
### Using helm to install OpenWhisk
+Installation expects `openwhisk` namespace to be created. To create, run
Review comment:
I merged already, so would need a new PR to take out the paragraph about creating the namespace. Would be great if you had the time to do that, but not critical.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] edokan commented on a change in pull request #650: Updated to include Windows tools
Posted by GitBox <gi...@apache.org>.
edokan commented on a change in pull request #650:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/650#discussion_r512231121
##########
File path: docs/k8s-docker-for-windows.md
##########
@@ -77,6 +77,10 @@ nginx:
### Using helm to install OpenWhisk
+Installation expects `openwhisk` namespace to be created. To create, run
Review comment:
I've just installed and its version is 3.1.2 . `helm help install` does not list `--create-namespace` among the flags. Being a newcomer on everything docker related, I've probably would never found that either. So I've included what worked, and probably will work for everyone to save a few like me from a google search.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org