[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5345: Parquet: Add option to set page row count limit

[GitBox <gi...@apache.org>]

stevenzwu commented on code in PR #5345:
URL: https://github.com/apache/iceberg/pull/5345#discussion_r930221404


##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -143,6 +143,10 @@ private TableProperties() {
   public static final String DELETE_PARQUET_PAGE_SIZE_BYTES = "write.delete.parquet.page-size-bytes";
   public static final int PARQUET_PAGE_SIZE_BYTES_DEFAULT = 1024 * 1024; // 1 MB
 
+  public static final String PARQUET_PAGE_ROW_LIMIT = "write.parquet.page-row-limit";
+  public static final String DELETE_PARQUET_PAGE_ROW_LIMIT = "write.delete.parquet.page-row-limit";

Review Comment:
   what about `page-row-count-limit`?
   
   Just `row-limit` can also be interpreted as row size/bytes limit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org