[jira] [Commented] (OAK-1181) Review node type definition for oak:queryIndexDefinition

["Jukka Zitting (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821730#comment-13821730 ] 

Jukka Zitting commented on OAK-1181:
------------------------------------

bq. incomplete list of properties compared to those mentioned in query.md

That's the reason why it extends nt:unstructured. I don't think it makes sense to add or modify a new index definition node type whenever we add a new index plugin.

bq. 'async' property is string with a predefined value 'async': why not boolean?

It's possible to have multiple different AsyncIndexUpdate tasks running against a repository, each with a separate name. The default one is called "async", but others could well be added to distribute the work of updating multiple different asynchronous indexes.

bq. index content stored underneath the definition has not dedicated node type.

The index content is hidden from anything that works above the Oak API, so there's no need (or point) for it to have a node type.

bq. is it expected that an index definition has custom properties?

Yes.

bq. is it expected that such custom properties have other property types that STRING/NAME/BOOLEAN? e.g. a binary?

Yes. For example a complex indexer might allow a custom indexing script to be included as a part of the index definition.

bq. is it expected that an index definition has other child nodes that the index content itself?

Yes, see above. For example consider the need to implement similar custom index configuration rules as we currently have for Jackrabbit 2.x: http://wiki.apache.org/jackrabbit/IndexingConfiguration

> Review node type definition for oak:queryIndexDefinition
> --------------------------------------------------------
>
>                 Key: OAK-1181
>                 URL: https://issues.apache.org/jira/browse/OAK-1181
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: core
>            Reporter: angela
>             Fix For: 0.14
>
>
> things to review:
> - name not following naming convention
> - extending from nt:unstructured
> - OPV flags (behavior upon versioning of the parent node)
> - incomplete list of properties compared to those mentioned in query.md
> - 'async' property is string with a predefined value 'async': why not boolean?
> - index content stored underneath the definition has not dedicated node type.
> things to consider:
> - is it expected that an index definition has custom properties?
> - is it expected that such custom properties have other property types that STRING/NAME/BOOLEAN? e.g. a binary?
> - is it expected that an index definition has other child nodes that the index content itself?



--
This message was sent by Atlassian JIRA
(v6.1#6144)