[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on a change in pull request #48: SLING-9961: remove addSystemUserPath

[GitBox <gi...@apache.org>]

anchela commented on a change in pull request #48:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/48#discussion_r556511877



##########
File path: src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java
##########
@@ -105,34 +100,15 @@ public void addRepoinitExtension(@NotNull List<VaultPackageAssembler> packageAss
             // system users
 
             for (SystemUser systemUser : systemUsers) {
-                // TODO does it harm?!?
-                addSystemUserPath(formatter, systemUser.getIntermediatePath());
-
                 // make sure all users are created first
-
                 formatter.format("create service user %s with path %s%n", systemUser.getId(), systemUser.getIntermediatePath());
-
-                // clean the unneeded ACLs, see SLING-8561

Review comment:
       i think it's ok.... but at a first glance i got confused by the removal of this line...... because what it refers to rather falls into SLING-9953.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org