You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by jrushf1239k <gi...@git.apache.org> on 2016/02/12 17:17:17 UTC
[GitHub] trafficserver pull request: fixed a bug where a parent is not mark...
GitHub user jrushf1239k opened a pull request:
https://github.com/apache/trafficserver/pull/473
fixed a bug where a parent is not marked down due to a race updating …
…the parent record failCount. Added a fix to only mark up retryable parents in HttpTransact when the retry is successful.
See TS-4199
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jrushf1239k/trafficserver ts4199
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/473.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #473
----
commit 34a2cac89c7be3945b945d662cad8266ab6f2085
Author: John J. Rushford <jo...@cable.comcast.com>
Date: 2016-02-12T16:08:11Z
fixed a bug where a parent is not marked down due to a race updating the parent record failCount. Added a fix to only mark up retryable parents in HttpTransact when the retry is successful.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: fixed a bug where a parent is not mark...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/473#issuecomment-183425676
Sounds good, +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: fixed a bug where a parent is not mark...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/473
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: fixed a bug where a parent is not mark...
Posted by jrushf1239k <gi...@git.apache.org>.
Github user jrushf1239k commented on the pull request:
https://github.com/apache/trafficserver/pull/473#issuecomment-183425465
Yes, it’s being done in HttpTransact::handle_response_from_parent() when the parent is marked for retry, “parent_result->retry == true”. There it’s marked up only when there is a good connection.
Thanks
--
John J. Rushford
IPCDN Engineering
1400 Wewatta Street, Denver Colorado 80202
John_Rushford@cable.comcast.com
From: Leif Hedstrom <no...@github.com>>
Reply-To: apache/trafficserver <re...@reply.github.com>>
Date: Friday, February 12, 2016 at 10:36 AM
To: apache/trafficserver <tr...@noreply.github.com>>
Cc: John Rushford <jo...@cable.comcast.com>>
Subject: Re: [trafficserver] fixed a bug where a parent is not marked down due to a race updating … (#473)
Cool. One (stupid) question: You remove the call to markParentUp(result), is that being done elsewhere in the existing code paths?
—
Reply to this email directly or view it on GitHub<https://github.com/apache/trafficserver/pull/473#issuecomment-183423695>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: fixed a bug where a parent is not mark...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/473#issuecomment-183423695
Cool. One (stupid) question: You remove the call to markParentUp(result), is that being done elsewhere in the existing code paths?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: fixed a bug where a parent is not mark...
Posted by jrushf1239k <gi...@git.apache.org>.
Github user jrushf1239k commented on the pull request:
https://github.com/apache/trafficserver/pull/473#issuecomment-183422438
Hi Leif,
Should be good now, I clang formatted it.
John
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: fixed a bug where a parent is not mark...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/473#issuecomment-183420183
Looks good, but I think it has to be run through clang-format.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---