[GitHub] dkuppitz commented on issue #1064: TINKERPOP-2159 EventStrategy doesn't handle multi-valued properties

[GitBox <gi...@apache.org>]

dkuppitz commented on issue #1064: TINKERPOP-2159 EventStrategy doesn't handle multi-valued properties
URL: https://github.com/apache/tinkerpop/pull/1064#issuecomment-465651139
 
 
   Well, the way it works now (in this PR) kinda makes sense. The current behavior has not been changed, new code paths were only introduced for the cases that threw exceptions previously:
   
   `Cardinality.list`: Now triggers a change event, with the old property always being empty (makes sense, because the new property will always be added and not change an existing one)
   `Cardinality.set`: The old property will be empty if the value doesn't exist yet, otherwise, it will be the property with the existing value.
   
   Not too bad, IMO. The proper way would be to change `VertexProperty`, so that it combines all values with the same key (e.g. in `The Crew` graph every person would have only one `location` property w/ multiple values), but that really is too much of a breaking change I think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services