You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2012/03/16 02:24:31 UTC
Review Request: Minor fix for enabling logging during tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4373/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and John Sirois.
Summary
-------
minor fix for enable gtest logging.
Diffs
-----
src/tests/main.cpp f4adf90
Diff: https://reviews.apache.org/r/4373/diff
Testing
-------
bin/mesos-tests.sh -v --gtest_filter=*TaskRunning*
Thanks,
Vinod
Re: Review Request: Minor fix for enabling logging during tests
Posted by Vinod Kone <vi...@gmail.com>.
> On 2012-03-16 15:02:13, Benjamin Hindman wrote:
> > Thanks Vinod!
>
> Benjamin Hindman wrote:
> What's most confusing to me, however, is that I don't seem to suffer from this bug!
>
>
>
> [benh@TW-MBP15-BHindman ~/workspace/apache-mesos3/build (trunk)]$ ./bin/mesos-tests.sh -v --gtest_filter=*SlavePart*
> Source directory: /Users/benh/workspace/apache-mesos3
> Build directory: /Users/benh/workspace/apache-mesos3/build
> Note: Google Test filter = *SlavePart*
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from FaultToleranceTest
> [ RUN ] FaultToleranceTest.SlavePartitioned
> I0316 08:03:31.731721 29913088 master.cpp:266] Master started at mesos://master@192.168.1.96:56226
> I0316 08:03:31.732548 29913088 master.cpp:281] Master ID: 2012031608031610721472-56226-88402
> I0316 08:03:31.732282 26836992 slave.cpp:158] Slave started at slave@192.168.1.96:56226
> I0316 08:03:31.732808 26836992 slave.cpp:159] Slave resources: cpus=2; mem=1024
> I0316 08:03:31.734295 29913088 master.cpp:483] Elected as master!
> I0316 08:03:31.734319 26836992 slave.cpp:324] New master detected at master@192.168.1.96:56226
> I0316 08:03:31.734892 29376512 master.cpp:843] Attempting to register slave 2012031608031610721472-56226-88402-0 at slave@192.168.1.96:56226
> I0316 08:03:31.734937 29376512 master.cpp:1096] Master now considering a slave at tw-mbp15-bhindman.gateway.2wire.net:56226 as active
> I0316 08:03:31.734973 29376512 master.cpp:1605] Adding slave 2012031608031610721472-56226-88402-0 at tw-mbp15-bhindman.gateway.2wire.net with cpus=2; mem=1024
> I0316 08:03:31.735139 29376512 simple_allocator.cpp:69] Added slave 2012031608031610721472-56226-88402-0 with cpus=2; mem=1024
> I0316 08:03:31.735241 29376512 slave.cpp:344] Registered with master; given slave ID 2012031608031610721472-56226-88402-0
> I0316 08:03:31.735440 29913088 master.cpp:525] Registering framework 2012031608031610721472-56226-88402-0000 at 4@192.168.1.96:56226
> I0316 08:03:31.735541 29913088 simple_allocator.cpp:46] Added framework 2012031608031610721472-56226-88402-0000
> I0316 08:03:31.735797 29913088 master.cpp:1187] Sending 1 offers to framework 2012031608031610721472-56226-88402-0000
> W0316 08:03:31.737289 29376512 master.cpp:1109] Removing slave 2012031608031610721472-56226-88402-0 at tw-mbp15-bhindman.gateway.2wire.net:56226 because it has been deactivated
> I0316 08:03:31.737794 29913088 slave.cpp:317] Slave asked to shut down
> I0316 08:03:31.737844 29913088 slave.cpp:295] Slave terminating
> I0316 08:03:31.738175 29376512 simple_allocator.cpp:81] Removed slave 2012031608031610721472-56226-88402-0
> I0316 08:03:31.738239 29376512 master.cpp:1118] Master now considering a slave at tw-mbp15-bhindman.gateway.2wire.net:56226 as inactive
> I0316 08:03:31.738276 29376512 master.cpp:417] Master terminating
> I0316 08:03:31.738473 1895898304 master.cpp:203] Shutting down master
> I0316 08:03:31.738739 1895898304 simple_allocator.cpp:59] Removed framework 2012031608031610721472-56226-88402-0000
> [ OK ] FaultToleranceTest.SlavePartitioned (9 ms)
> [----------] 1 test from FaultToleranceTest (9 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (9 ms total)
> [ PASSED ] 1 test.
>
> YOU HAVE 6 DISABLED TESTS
>
> [benh@TW-MBP15-BHindman ~/workspace/apache-mesos3/build (trunk)]$ cat ../src/tests/main.cpp
> /**
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> * distributed with this work for additional information
> * regarding copyright ownership. The ASF licenses this file
> * to you under the Apache License, Version 2.0 (the
> * "License"); you may not use this file except in compliance
> * with the License. You may obtain a copy of the License at
> *
> * http://www.apache.org/licenses/LICENSE-2.0
> *
> * Unless required by applicable law or agreed to in writing, software
> * distributed under the License is distributed on an "AS IS" BASIS,
> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> * See the License for the specific language governing permissions and
> * limitations under the License.
> */
>
> #include <glog/logging.h>
>
> #include <gtest/gtest.h>
>
> #include <string>
>
> #include <process/process.hpp>
>
> #include "common/utils.hpp"
>
> #include "configurator/configurator.hpp"
>
> #include "tests/utils.hpp"
>
> using namespace mesos::internal;
> using namespace mesos::internal::test;
>
> using std::string;
>
> int main(int argc, char** argv)
> {
> GOOGLE_PROTOBUF_VERIFY_VERSION;
>
> // Initialize glog.
> google::InitGoogleLogging("alltests");
>
> if (argc == 2 && strcmp("-v", argv[1]) == 0) {
> google::SetStderrLogging(google::INFO);
> }
>
> // Initialize gmock/gtest.
> testing::InitGoogleTest(&argc, argv);
> testing::FLAGS_gtest_death_test_style = "threadsafe";
>
> // Initialize libprocess (but not glog, done above).
> process::initialize(false);
>
> // Get the absolute path to the source (i.e., root) directory.
> Try<string> path = utils::os::realpath(SOURCE_DIR);
> CHECK(path.isSome()) << "Error getting source directory " << path.error();
> mesosSourceDirectory = path.get();
>
> std::cout << "Source directory: " << mesosSourceDirectory << std::endl;
>
> // Get absolute path to the build directory.
> path = utils::os::realpath(BUILD_DIR);
> CHECK(path.isSome()) << "Error getting build directory " << path.error();
> mesosBuildDirectory = path.get();
>
> std::cout << "Build directory: " << mesosBuildDirectory << std::endl;
>
> // Clear any MESOS_ environment variables so they don't affect our tests.
> Configurator::clearMesosEnvironmentVars();
>
> return RUN_ALL_TESTS();
> }
>
thats strange! did u do a configure/build?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4373/#review6038
-----------------------------------------------------------
On 2012-03-16 01:24:31, Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4373/
> -----------------------------------------------------------
>
> (Updated 2012-03-16 01:24:31)
>
>
> Review request for mesos, Benjamin Hindman and John Sirois.
>
>
> Summary
> -------
>
> minor fix for enable gtest logging.
>
>
> Diffs
> -----
>
> src/tests/main.cpp f4adf90
>
> Diff: https://reviews.apache.org/r/4373/diff
>
>
> Testing
> -------
>
> bin/mesos-tests.sh -v --gtest_filter=*TaskRunning*
>
>
> Thanks,
>
> Vinod
>
>
Re: Review Request: Minor fix for enabling logging during tests
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-03-16 15:02:13, Benjamin Hindman wrote:
> > Thanks Vinod!
>
> Benjamin Hindman wrote:
> What's most confusing to me, however, is that I don't seem to suffer from this bug!
>
>
>
> [benh@TW-MBP15-BHindman ~/workspace/apache-mesos3/build (trunk)]$ ./bin/mesos-tests.sh -v --gtest_filter=*SlavePart*
> Source directory: /Users/benh/workspace/apache-mesos3
> Build directory: /Users/benh/workspace/apache-mesos3/build
> Note: Google Test filter = *SlavePart*
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from FaultToleranceTest
> [ RUN ] FaultToleranceTest.SlavePartitioned
> I0316 08:03:31.731721 29913088 master.cpp:266] Master started at mesos://master@192.168.1.96:56226
> I0316 08:03:31.732548 29913088 master.cpp:281] Master ID: 2012031608031610721472-56226-88402
> I0316 08:03:31.732282 26836992 slave.cpp:158] Slave started at slave@192.168.1.96:56226
> I0316 08:03:31.732808 26836992 slave.cpp:159] Slave resources: cpus=2; mem=1024
> I0316 08:03:31.734295 29913088 master.cpp:483] Elected as master!
> I0316 08:03:31.734319 26836992 slave.cpp:324] New master detected at master@192.168.1.96:56226
> I0316 08:03:31.734892 29376512 master.cpp:843] Attempting to register slave 2012031608031610721472-56226-88402-0 at slave@192.168.1.96:56226
> I0316 08:03:31.734937 29376512 master.cpp:1096] Master now considering a slave at tw-mbp15-bhindman.gateway.2wire.net:56226 as active
> I0316 08:03:31.734973 29376512 master.cpp:1605] Adding slave 2012031608031610721472-56226-88402-0 at tw-mbp15-bhindman.gateway.2wire.net with cpus=2; mem=1024
> I0316 08:03:31.735139 29376512 simple_allocator.cpp:69] Added slave 2012031608031610721472-56226-88402-0 with cpus=2; mem=1024
> I0316 08:03:31.735241 29376512 slave.cpp:344] Registered with master; given slave ID 2012031608031610721472-56226-88402-0
> I0316 08:03:31.735440 29913088 master.cpp:525] Registering framework 2012031608031610721472-56226-88402-0000 at 4@192.168.1.96:56226
> I0316 08:03:31.735541 29913088 simple_allocator.cpp:46] Added framework 2012031608031610721472-56226-88402-0000
> I0316 08:03:31.735797 29913088 master.cpp:1187] Sending 1 offers to framework 2012031608031610721472-56226-88402-0000
> W0316 08:03:31.737289 29376512 master.cpp:1109] Removing slave 2012031608031610721472-56226-88402-0 at tw-mbp15-bhindman.gateway.2wire.net:56226 because it has been deactivated
> I0316 08:03:31.737794 29913088 slave.cpp:317] Slave asked to shut down
> I0316 08:03:31.737844 29913088 slave.cpp:295] Slave terminating
> I0316 08:03:31.738175 29376512 simple_allocator.cpp:81] Removed slave 2012031608031610721472-56226-88402-0
> I0316 08:03:31.738239 29376512 master.cpp:1118] Master now considering a slave at tw-mbp15-bhindman.gateway.2wire.net:56226 as inactive
> I0316 08:03:31.738276 29376512 master.cpp:417] Master terminating
> I0316 08:03:31.738473 1895898304 master.cpp:203] Shutting down master
> I0316 08:03:31.738739 1895898304 simple_allocator.cpp:59] Removed framework 2012031608031610721472-56226-88402-0000
> [ OK ] FaultToleranceTest.SlavePartitioned (9 ms)
> [----------] 1 test from FaultToleranceTest (9 ms total)
>
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (9 ms total)
> [ PASSED ] 1 test.
>
> YOU HAVE 6 DISABLED TESTS
>
> [benh@TW-MBP15-BHindman ~/workspace/apache-mesos3/build (trunk)]$ cat ../src/tests/main.cpp
> /**
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> * distributed with this work for additional information
> * regarding copyright ownership. The ASF licenses this file
> * to you under the Apache License, Version 2.0 (the
> * "License"); you may not use this file except in compliance
> * with the License. You may obtain a copy of the License at
> *
> * http://www.apache.org/licenses/LICENSE-2.0
> *
> * Unless required by applicable law or agreed to in writing, software
> * distributed under the License is distributed on an "AS IS" BASIS,
> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> * See the License for the specific language governing permissions and
> * limitations under the License.
> */
>
> #include <glog/logging.h>
>
> #include <gtest/gtest.h>
>
> #include <string>
>
> #include <process/process.hpp>
>
> #include "common/utils.hpp"
>
> #include "configurator/configurator.hpp"
>
> #include "tests/utils.hpp"
>
> using namespace mesos::internal;
> using namespace mesos::internal::test;
>
> using std::string;
>
> int main(int argc, char** argv)
> {
> GOOGLE_PROTOBUF_VERIFY_VERSION;
>
> // Initialize glog.
> google::InitGoogleLogging("alltests");
>
> if (argc == 2 && strcmp("-v", argv[1]) == 0) {
> google::SetStderrLogging(google::INFO);
> }
>
> // Initialize gmock/gtest.
> testing::InitGoogleTest(&argc, argv);
> testing::FLAGS_gtest_death_test_style = "threadsafe";
>
> // Initialize libprocess (but not glog, done above).
> process::initialize(false);
>
> // Get the absolute path to the source (i.e., root) directory.
> Try<string> path = utils::os::realpath(SOURCE_DIR);
> CHECK(path.isSome()) << "Error getting source directory " << path.error();
> mesosSourceDirectory = path.get();
>
> std::cout << "Source directory: " << mesosSourceDirectory << std::endl;
>
> // Get absolute path to the build directory.
> path = utils::os::realpath(BUILD_DIR);
> CHECK(path.isSome()) << "Error getting build directory " << path.error();
> mesosBuildDirectory = path.get();
>
> std::cout << "Build directory: " << mesosBuildDirectory << std::endl;
>
> // Clear any MESOS_ environment variables so they don't affect our tests.
> Configurator::clearMesosEnvironmentVars();
>
> return RUN_ALL_TESTS();
> }
>
>
> Vinod Kone wrote:
> thats strange! did u do a configure/build?
Huh? When I build the code WITHOUT the patch I seem to not experience the bug.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4373/#review6038
-----------------------------------------------------------
On 2012-03-16 01:24:31, Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4373/
> -----------------------------------------------------------
>
> (Updated 2012-03-16 01:24:31)
>
>
> Review request for mesos, Benjamin Hindman and John Sirois.
>
>
> Summary
> -------
>
> minor fix for enable gtest logging.
>
>
> Diffs
> -----
>
> src/tests/main.cpp f4adf90
>
> Diff: https://reviews.apache.org/r/4373/diff
>
>
> Testing
> -------
>
> bin/mesos-tests.sh -v --gtest_filter=*TaskRunning*
>
>
> Thanks,
>
> Vinod
>
>
Re: Review Request: Minor fix for enabling logging during tests
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-03-16 15:02:13, Benjamin Hindman wrote:
> > Thanks Vinod!
What's most confusing to me, however, is that I don't seem to suffer from this bug!
[benh@TW-MBP15-BHindman ~/workspace/apache-mesos3/build (trunk)]$ ./bin/mesos-tests.sh -v --gtest_filter=*SlavePart*
Source directory: /Users/benh/workspace/apache-mesos3
Build directory: /Users/benh/workspace/apache-mesos3/build
Note: Google Test filter = *SlavePart*
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from FaultToleranceTest
[ RUN ] FaultToleranceTest.SlavePartitioned
I0316 08:03:31.731721 29913088 master.cpp:266] Master started at mesos://master@192.168.1.96:56226
I0316 08:03:31.732548 29913088 master.cpp:281] Master ID: 2012031608031610721472-56226-88402
I0316 08:03:31.732282 26836992 slave.cpp:158] Slave started at slave@192.168.1.96:56226
I0316 08:03:31.732808 26836992 slave.cpp:159] Slave resources: cpus=2; mem=1024
I0316 08:03:31.734295 29913088 master.cpp:483] Elected as master!
I0316 08:03:31.734319 26836992 slave.cpp:324] New master detected at master@192.168.1.96:56226
I0316 08:03:31.734892 29376512 master.cpp:843] Attempting to register slave 2012031608031610721472-56226-88402-0 at slave@192.168.1.96:56226
I0316 08:03:31.734937 29376512 master.cpp:1096] Master now considering a slave at tw-mbp15-bhindman.gateway.2wire.net:56226 as active
I0316 08:03:31.734973 29376512 master.cpp:1605] Adding slave 2012031608031610721472-56226-88402-0 at tw-mbp15-bhindman.gateway.2wire.net with cpus=2; mem=1024
I0316 08:03:31.735139 29376512 simple_allocator.cpp:69] Added slave 2012031608031610721472-56226-88402-0 with cpus=2; mem=1024
I0316 08:03:31.735241 29376512 slave.cpp:344] Registered with master; given slave ID 2012031608031610721472-56226-88402-0
I0316 08:03:31.735440 29913088 master.cpp:525] Registering framework 2012031608031610721472-56226-88402-0000 at 4@192.168.1.96:56226
I0316 08:03:31.735541 29913088 simple_allocator.cpp:46] Added framework 2012031608031610721472-56226-88402-0000
I0316 08:03:31.735797 29913088 master.cpp:1187] Sending 1 offers to framework 2012031608031610721472-56226-88402-0000
W0316 08:03:31.737289 29376512 master.cpp:1109] Removing slave 2012031608031610721472-56226-88402-0 at tw-mbp15-bhindman.gateway.2wire.net:56226 because it has been deactivated
I0316 08:03:31.737794 29913088 slave.cpp:317] Slave asked to shut down
I0316 08:03:31.737844 29913088 slave.cpp:295] Slave terminating
I0316 08:03:31.738175 29376512 simple_allocator.cpp:81] Removed slave 2012031608031610721472-56226-88402-0
I0316 08:03:31.738239 29376512 master.cpp:1118] Master now considering a slave at tw-mbp15-bhindman.gateway.2wire.net:56226 as inactive
I0316 08:03:31.738276 29376512 master.cpp:417] Master terminating
I0316 08:03:31.738473 1895898304 master.cpp:203] Shutting down master
I0316 08:03:31.738739 1895898304 simple_allocator.cpp:59] Removed framework 2012031608031610721472-56226-88402-0000
[ OK ] FaultToleranceTest.SlavePartitioned (9 ms)
[----------] 1 test from FaultToleranceTest (9 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (9 ms total)
[ PASSED ] 1 test.
YOU HAVE 6 DISABLED TESTS
[benh@TW-MBP15-BHindman ~/workspace/apache-mesos3/build (trunk)]$ cat ../src/tests/main.cpp
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <glog/logging.h>
#include <gtest/gtest.h>
#include <string>
#include <process/process.hpp>
#include "common/utils.hpp"
#include "configurator/configurator.hpp"
#include "tests/utils.hpp"
using namespace mesos::internal;
using namespace mesos::internal::test;
using std::string;
int main(int argc, char** argv)
{
GOOGLE_PROTOBUF_VERIFY_VERSION;
// Initialize glog.
google::InitGoogleLogging("alltests");
if (argc == 2 && strcmp("-v", argv[1]) == 0) {
google::SetStderrLogging(google::INFO);
}
// Initialize gmock/gtest.
testing::InitGoogleTest(&argc, argv);
testing::FLAGS_gtest_death_test_style = "threadsafe";
// Initialize libprocess (but not glog, done above).
process::initialize(false);
// Get the absolute path to the source (i.e., root) directory.
Try<string> path = utils::os::realpath(SOURCE_DIR);
CHECK(path.isSome()) << "Error getting source directory " << path.error();
mesosSourceDirectory = path.get();
std::cout << "Source directory: " << mesosSourceDirectory << std::endl;
// Get absolute path to the build directory.
path = utils::os::realpath(BUILD_DIR);
CHECK(path.isSome()) << "Error getting build directory " << path.error();
mesosBuildDirectory = path.get();
std::cout << "Build directory: " << mesosBuildDirectory << std::endl;
// Clear any MESOS_ environment variables so they don't affect our tests.
Configurator::clearMesosEnvironmentVars();
return RUN_ALL_TESTS();
}
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4373/#review6038
-----------------------------------------------------------
On 2012-03-16 01:24:31, Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4373/
> -----------------------------------------------------------
>
> (Updated 2012-03-16 01:24:31)
>
>
> Review request for mesos, Benjamin Hindman and John Sirois.
>
>
> Summary
> -------
>
> minor fix for enable gtest logging.
>
>
> Diffs
> -----
>
> src/tests/main.cpp f4adf90
>
> Diff: https://reviews.apache.org/r/4373/diff
>
>
> Testing
> -------
>
> bin/mesos-tests.sh -v --gtest_filter=*TaskRunning*
>
>
> Thanks,
>
> Vinod
>
>
Re: Review Request: Minor fix for enabling logging during tests
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4373/#review6038
-----------------------------------------------------------
Ship it!
Thanks Vinod!
- Benjamin
On 2012-03-16 01:24:31, Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4373/
> -----------------------------------------------------------
>
> (Updated 2012-03-16 01:24:31)
>
>
> Review request for mesos, Benjamin Hindman and John Sirois.
>
>
> Summary
> -------
>
> minor fix for enable gtest logging.
>
>
> Diffs
> -----
>
> src/tests/main.cpp f4adf90
>
> Diff: https://reviews.apache.org/r/4373/diff
>
>
> Testing
> -------
>
> bin/mesos-tests.sh -v --gtest_filter=*TaskRunning*
>
>
> Thanks,
>
> Vinod
>
>