You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/13 17:24:59 UTC

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #6655: [BYOC] Added default_tuples parameter to AnnotateTarget pass

zhiics commented on a change in pull request #6655:
URL: https://github.com/apache/incubator-tvm/pull/6655#discussion_r504131348



##########
File path: python/tvm/relay/transform/transform.py
##########
@@ -666,7 +666,7 @@ def PartitionGraph():
     return _ffi_api.PartitionGraph()
 
 
-def AnnotateTarget(targets):
+def AnnotateTarget(targets, default_tuples=False):

Review comment:
       This API sounds quite ad-hoc to me. `Tuple` is just one of the nodes that can take the same target from its inputs/args. Incrementally adding parameters to handle different nodes would make the API bulky and code less readable, IMHO.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org