You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/06/20 12:32:09 UTC
[GitHub] [incubator-shenyu] MarsOu1995 opened a new pull request #1656: feature IpUtils: Multi-network environment optimization.
MarsOu1995 opened a new pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656
Add a parameter to get the desired IP based on the prefix.
// Describe your PR here; eg. Fixes #1655
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://dromara.org/projects/soul/contributor/).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `mvn clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] MarsOu1995 commented on pull request #1656: feature IpUtils: Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
MarsOu1995 commented on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864916788
Ok, it has been modified .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864549493
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1656](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2d52006) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/cb452662429a641eda65605f8524cbe284b2f7e1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb45266) will **decrease** coverage by `1.31%`.
> The diff coverage is `47.36%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1656 +/- ##
============================================
- Coverage 63.38% 62.06% -1.32%
+ Complexity 2249 2211 -38
============================================
Files 460 460
Lines 9659 9558 -101
Branches 976 976
============================================
- Hits 6122 5932 -190
- Misses 3042 3134 +92
+ Partials 495 492 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...alibaba/dubbo/AlibabaDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9hbGliYWJhL2R1YmJvL0FsaWJhYmFEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...t/apache/dubbo/ApacheDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvY2xpZW50L2FwYWNoZS9kdWJiby9BcGFjaGVEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ient/springcloud/init/ContextRegisterListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L0NvbnRleHRSZWdpc3Rlckxpc3RlbmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `29.72% <0.00%> (-60.94%)` | :arrow_down: |
| [...n/java/org/apache/shenyu/common/utils/IpUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9JcFV0aWxzLmphdmE=) | `70.00% <61.53%> (-3.69%)` | :arrow_down: |
| [...cloud/init/SpringCloudClientBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L1NwcmluZ0Nsb3VkQ2xpZW50QmVhblBvc3RQcm9jZXNzb3IuamF2YQ==) | `77.04% <100.00%> (+1.63%)` | :arrow_up: |
| [...ache/shenyu/admin/exception/ExceptionHandlers.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZXhjZXB0aW9uL0V4Y2VwdGlvbkhhbmRsZXJzLmphdmE=) | `30.55% <0.00%> (-42.78%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `72.22% <0.00%> (-22.23%)` | :arrow_down: |
| [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `54.73% <0.00%> (-9.48%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb45266...2d52006](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] MarsOu1995 commented on a change in pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
MarsOu1995 commented on a change in pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#discussion_r655496320
##########
File path: shenyu-client/shenyu-client-dubbo/shenyu-client-apache-dubbo/src/main/java/org/apache/shenyu/client/apache/dubbo/ApacheDubboServiceBeanListener.java
##########
@@ -104,7 +104,7 @@ private MetaDataRegisterDTO buildMetaDataDTO(final ServiceBean serviceBean, fina
String path = contextPath + shenyuDubboClient.path();
String desc = shenyuDubboClient.desc();
String serviceName = serviceBean.getInterface();
- String host = StringUtils.isBlank(this.host) ? IpUtils.getHost() : this.host;
+ String host = IpUtils.getHost(this.host);
Review comment:
The "host" configuration is currently only for the "client-plugin", so I changed it all directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864549493
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1656](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d01db8) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/cb452662429a641eda65605f8524cbe284b2f7e1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb45266) will **decrease** coverage by `0.88%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1656 +/- ##
============================================
- Coverage 63.38% 62.49% -0.89%
+ Complexity 2249 2220 -29
============================================
Files 460 460
Lines 9659 9558 -101
Branches 976 976
============================================
- Hits 6122 5973 -149
- Misses 3042 3090 +48
Partials 495 495
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...alibaba/dubbo/AlibabaDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9hbGliYWJhL2R1YmJvL0FsaWJhYmFEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...t/apache/dubbo/ApacheDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvY2xpZW50L2FwYWNoZS9kdWJiby9BcGFjaGVEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ient/springcloud/init/ContextRegisterListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L0NvbnRleHRSZWdpc3Rlckxpc3RlbmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/shenyu/common/utils/IpUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9JcFV0aWxzLmphdmE=) | `70.00% <61.53%> (-3.69%)` | :arrow_down: |
| [...cloud/init/SpringCloudClientBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L1NwcmluZ0Nsb3VkQ2xpZW50QmVhblBvc3RQcm9jZXNzb3IuamF2YQ==) | `77.04% <100.00%> (+1.63%)` | :arrow_up: |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `91.89% <100.00%> (+1.22%)` | :arrow_up: |
| [...ache/shenyu/admin/exception/ExceptionHandlers.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZXhjZXB0aW9uL0V4Y2VwdGlvbkhhbmRsZXJzLmphdmE=) | `30.55% <0.00%> (-42.78%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `77.77% <0.00%> (-16.67%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `65.04% <0.00%> (-9.71%)` | :arrow_down: |
| [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `54.73% <0.00%> (-9.48%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb45266...5d01db8](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] MarsOu1995 commented on a change in pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
MarsOu1995 commented on a change in pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#discussion_r655584491
##########
File path: shenyu-client/shenyu-client-dubbo/shenyu-client-apache-dubbo/src/main/java/org/apache/shenyu/client/apache/dubbo/ApacheDubboServiceBeanListener.java
##########
@@ -104,7 +104,7 @@ private MetaDataRegisterDTO buildMetaDataDTO(final ServiceBean serviceBean, fina
String path = contextPath + shenyuDubboClient.path();
String desc = shenyuDubboClient.desc();
String serviceName = serviceBean.getInterface();
- String host = StringUtils.isBlank(this.host) ? IpUtils.getHost() : this.host;
+ String host = IpUtils.getHost(this.host);
Review comment:
Latest push：
Added method to verify 'host' is a complete network host, and getHost() adds wildcard matching.
'?' only can match one, '\*' can match one and more.
for example:
(192.168.* or 192.168) can match (192.168.10.166,192.168.50.32).
(192.168.10.?) can match 192.168.10.166.
(192.168.10.166) only can match 192.168.10.166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 removed a comment on pull request #1656: feature IpUtils: Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
yu199195 removed a comment on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864919627
see this : https://github.com/apache/incubator-shenyu/issues/160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864549493
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1656](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2d52006) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/cb452662429a641eda65605f8524cbe284b2f7e1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb45266) will **decrease** coverage by `0.81%`.
> The diff coverage is `47.36%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1656 +/- ##
============================================
- Coverage 63.38% 62.56% -0.82%
+ Complexity 2249 2221 -28
============================================
Files 460 460
Lines 9659 9558 -101
Branches 976 976
============================================
- Hits 6122 5980 -142
- Misses 3042 3085 +43
+ Partials 495 493 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...alibaba/dubbo/AlibabaDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9hbGliYWJhL2R1YmJvL0FsaWJhYmFEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...t/apache/dubbo/ApacheDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvY2xpZW50L2FwYWNoZS9kdWJiby9BcGFjaGVEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ient/springcloud/init/ContextRegisterListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L0NvbnRleHRSZWdpc3Rlckxpc3RlbmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `59.45% <0.00%> (-31.21%)` | :arrow_down: |
| [...n/java/org/apache/shenyu/common/utils/IpUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9JcFV0aWxzLmphdmE=) | `70.00% <61.53%> (-3.69%)` | :arrow_down: |
| [...cloud/init/SpringCloudClientBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L1NwcmluZ0Nsb3VkQ2xpZW50QmVhblBvc3RQcm9jZXNzb3IuamF2YQ==) | `77.04% <100.00%> (+1.63%)` | :arrow_up: |
| [...ache/shenyu/admin/exception/ExceptionHandlers.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZXhjZXB0aW9uL0V4Y2VwdGlvbkhhbmRsZXJzLmphdmE=) | `30.55% <0.00%> (-42.78%)` | :arrow_down: |
| [.../admin/service/impl/DataPermissionServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL0RhdGFQZXJtaXNzaW9uU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (-6.85%)` | :arrow_down: |
| [...enyu/admin/service/impl/PermissionServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Blcm1pc3Npb25TZXJ2aWNlSW1wbC5qYXZh) | `54.54% <0.00%> (-5.99%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb45266...2d52006](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 commented on pull request #1656: feature IpUtils: Multi-network environment optimization.
Posted by GitBox <gi...@apache.org>.
yu199195 commented on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864913811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864549493
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1656](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d01db8) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/cb452662429a641eda65605f8524cbe284b2f7e1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb45266) will **decrease** coverage by `1.41%`.
> The diff coverage is `47.36%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1656 +/- ##
============================================
- Coverage 63.38% 61.96% -1.42%
+ Complexity 2249 2211 -38
============================================
Files 460 460
Lines 9659 9558 -101
Branches 976 976
============================================
- Hits 6122 5923 -199
- Misses 3042 3140 +98
Partials 495 495
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...alibaba/dubbo/AlibabaDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9hbGliYWJhL2R1YmJvL0FsaWJhYmFEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...t/apache/dubbo/ApacheDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvY2xpZW50L2FwYWNoZS9kdWJiby9BcGFjaGVEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ient/springcloud/init/ContextRegisterListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L0NvbnRleHRSZWdpc3Rlckxpc3RlbmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `29.72% <0.00%> (-60.94%)` | :arrow_down: |
| [...n/java/org/apache/shenyu/common/utils/IpUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9JcFV0aWxzLmphdmE=) | `70.00% <61.53%> (-3.69%)` | :arrow_down: |
| [...cloud/init/SpringCloudClientBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L1NwcmluZ0Nsb3VkQ2xpZW50QmVhblBvc3RQcm9jZXNzb3IuamF2YQ==) | `77.04% <100.00%> (+1.63%)` | :arrow_up: |
| [...ache/shenyu/admin/exception/ExceptionHandlers.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZXhjZXB0aW9uL0V4Y2VwdGlvbkhhbmRsZXJzLmphdmE=) | `30.55% <0.00%> (-42.78%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `72.22% <0.00%> (-22.23%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `63.10% <0.00%> (-11.66%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb45266...5d01db8](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 merged pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
yu199195 merged pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] MarsOu1995 commented on pull request #1656: feature IpUtils: Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
MarsOu1995 commented on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864924311
Do you mean to implement a plugin to complete the selection of network?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dengliming commented on a change in pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
dengliming commented on a change in pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#discussion_r655436490
##########
File path: shenyu-common/src/main/java/org/apache/shenyu/common/utils/IpUtils.java
##########
@@ -34,6 +34,18 @@ private IpUtils() {
* @return the host
*/
public static String getHost() {
+ return getHost(null);
+ }
+
+ /**
+ * Gets host.
+ *
+ * @param preferred host preferred str
+ * @return the host
+ */
+ public static String getHost(final String preferred) {
Review comment:
`getHost(final String filterPrefix)` maybe better.
##########
File path: shenyu-common/src/main/java/org/apache/shenyu/common/utils/IpUtils.java
##########
@@ -44,11 +56,25 @@ public static String getHost() {
InetAddress inetAddress = (InetAddress) addresses.nextElement();
String hostAddress = inetAddress.getHostAddress();
if (hostAddress.contains(".") && !inetAddress.isLoopbackAddress()) {
- hostIp = hostAddress;
- break;
+ if (first) {
+ firstHostIp = hostAddress;
+ first = false;
Review comment:
You don't need to check `first`.
```
if (firstHostIp == null) {
firstHostIp = hostAddress;
}
```
##########
File path: shenyu-client/shenyu-client-dubbo/shenyu-client-apache-dubbo/src/main/java/org/apache/shenyu/client/apache/dubbo/ApacheDubboServiceBeanListener.java
##########
@@ -104,7 +104,7 @@ private MetaDataRegisterDTO buildMetaDataDTO(final ServiceBean serviceBean, fina
String path = contextPath + shenyuDubboClient.path();
String desc = shenyuDubboClient.desc();
String serviceName = serviceBean.getInterface();
- String host = StringUtils.isBlank(this.host) ? IpUtils.getHost() : this.host;
+ String host = IpUtils.getHost(this.host);
Review comment:
I think it would be better if `host` and `hostPrefix` were configured separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1656: feature IpUtils: Multi-network environment optimization.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864549493
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1656](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (62d2fba) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/cb452662429a641eda65605f8524cbe284b2f7e1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb45266) will **decrease** coverage by `1.10%`.
> The diff coverage is `52.94%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1656 +/- ##
============================================
- Coverage 63.38% 62.27% -1.11%
+ Complexity 2249 2217 -32
============================================
Files 460 460
Lines 9659 9556 -103
Branches 976 975 -1
============================================
- Hits 6122 5951 -171
- Misses 3042 3109 +67
- Partials 495 496 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...alibaba/dubbo/AlibabaDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9hbGliYWJhL2R1YmJvL0FsaWJhYmFEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...t/apache/dubbo/ApacheDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvY2xpZW50L2FwYWNoZS9kdWJiby9BcGFjaGVEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ient/springcloud/init/ContextRegisterListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L0NvbnRleHRSZWdpc3Rlckxpc3RlbmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `35.13% <0.00%> (-55.54%)` | :arrow_down: |
| [...n/java/org/apache/shenyu/common/utils/IpUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9JcFV0aWxzLmphdmE=) | `75.00% <72.72%> (+1.31%)` | :arrow_up: |
| [...cloud/init/SpringCloudClientBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L1NwcmluZ0Nsb3VkQ2xpZW50QmVhblBvc3RQcm9jZXNzb3IuamF2YQ==) | `77.04% <100.00%> (+1.63%)` | :arrow_up: |
| [...ache/shenyu/admin/exception/ExceptionHandlers.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZXhjZXB0aW9uL0V4Y2VwdGlvbkhhbmRsZXJzLmphdmE=) | `30.55% <0.00%> (-42.78%)` | :arrow_down: |
| [.../admin/service/impl/DataPermissionServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL0RhdGFQZXJtaXNzaW9uU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (-6.85%)` | :arrow_down: |
| [...enyu/admin/service/impl/PermissionServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Blcm1pc3Npb25TZXJ2aWNlSW1wbC5qYXZh) | `54.54% <0.00%> (-5.99%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb45266...62d2fba](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] MarsOu1995 commented on a change in pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
MarsOu1995 commented on a change in pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#discussion_r655489231
##########
File path: shenyu-common/src/main/java/org/apache/shenyu/common/utils/IpUtils.java
##########
@@ -34,6 +34,18 @@ private IpUtils() {
* @return the host
*/
public static String getHost() {
+ return getHost(null);
+ }
+
+ /**
+ * Gets host.
+ *
+ * @param preferred host preferred str
+ * @return the host
+ */
+ public static String getHost(final String preferred) {
Review comment:
yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] MarsOu1995 commented on a change in pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
MarsOu1995 commented on a change in pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#discussion_r655584491
##########
File path: shenyu-client/shenyu-client-dubbo/shenyu-client-apache-dubbo/src/main/java/org/apache/shenyu/client/apache/dubbo/ApacheDubboServiceBeanListener.java
##########
@@ -104,7 +104,7 @@ private MetaDataRegisterDTO buildMetaDataDTO(final ServiceBean serviceBean, fina
String path = contextPath + shenyuDubboClient.path();
String desc = shenyuDubboClient.desc();
String serviceName = serviceBean.getInterface();
- String host = StringUtils.isBlank(this.host) ? IpUtils.getHost() : this.host;
+ String host = IpUtils.getHost(this.host);
Review comment:
Latest push：
Added method to verify 'host' is a complete network host, and getHost() adds wildcard matching.
'?' only can match one, '*' can match one and more.
for example:
(192.168.* or 192.168) can match (192.168.10.166,192.168.50.32).
(192.168.10.?) can match 192.168.10.166.
(192.168.10.166) only can match 192.168.10.166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] MarsOu1995 commented on a change in pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
MarsOu1995 commented on a change in pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#discussion_r655483858
##########
File path: shenyu-common/src/main/java/org/apache/shenyu/common/utils/IpUtils.java
##########
@@ -44,11 +56,25 @@ public static String getHost() {
InetAddress inetAddress = (InetAddress) addresses.nextElement();
String hostAddress = inetAddress.getHostAddress();
if (hostAddress.contains(".") && !inetAddress.isLoopbackAddress()) {
- hostIp = hostAddress;
- break;
+ if (first) {
+ firstHostIp = hostAddress;
+ first = false;
Review comment:
Yes it would be better
##########
File path: shenyu-client/shenyu-client-dubbo/shenyu-client-apache-dubbo/src/main/java/org/apache/shenyu/client/apache/dubbo/ApacheDubboServiceBeanListener.java
##########
@@ -104,7 +104,7 @@ private MetaDataRegisterDTO buildMetaDataDTO(final ServiceBean serviceBean, fina
String path = contextPath + shenyuDubboClient.path();
String desc = shenyuDubboClient.desc();
String serviceName = serviceBean.getInterface();
- String host = StringUtils.isBlank(this.host) ? IpUtils.getHost() : this.host;
+ String host = IpUtils.getHost(this.host);
Review comment:
If'host' is empty, then get the first ip. If it is an incomplete ip, the first suitable one will be matched.
If your input is complete, this is the one you get. After all, you are unlikely to have two IPs on the same network segment.
##########
File path: shenyu-common/src/main/java/org/apache/shenyu/common/utils/IpUtils.java
##########
@@ -34,6 +34,18 @@ private IpUtils() {
* @return the host
*/
public static String getHost() {
+ return getHost(null);
+ }
+
+ /**
+ * Gets host.
+ *
+ * @param preferred host preferred str
+ * @return the host
+ */
+ public static String getHost(final String preferred) {
Review comment:
yes.
##########
File path: shenyu-client/shenyu-client-dubbo/shenyu-client-apache-dubbo/src/main/java/org/apache/shenyu/client/apache/dubbo/ApacheDubboServiceBeanListener.java
##########
@@ -104,7 +104,7 @@ private MetaDataRegisterDTO buildMetaDataDTO(final ServiceBean serviceBean, fina
String path = contextPath + shenyuDubboClient.path();
String desc = shenyuDubboClient.desc();
String serviceName = serviceBean.getInterface();
- String host = StringUtils.isBlank(this.host) ? IpUtils.getHost() : this.host;
+ String host = IpUtils.getHost(this.host);
Review comment:
The "host" configuration is currently only for the "client-plugin", so I changed it all directly.
##########
File path: shenyu-client/shenyu-client-dubbo/shenyu-client-apache-dubbo/src/main/java/org/apache/shenyu/client/apache/dubbo/ApacheDubboServiceBeanListener.java
##########
@@ -104,7 +104,7 @@ private MetaDataRegisterDTO buildMetaDataDTO(final ServiceBean serviceBean, fina
String path = contextPath + shenyuDubboClient.path();
String desc = shenyuDubboClient.desc();
String serviceName = serviceBean.getInterface();
- String host = StringUtils.isBlank(this.host) ? IpUtils.getHost() : this.host;
+ String host = IpUtils.getHost(this.host);
Review comment:
Or we can optimize the internal implementation of the method.
Distinguish the use of 'startwith' or 'equals'.
##########
File path: shenyu-client/shenyu-client-dubbo/shenyu-client-apache-dubbo/src/main/java/org/apache/shenyu/client/apache/dubbo/ApacheDubboServiceBeanListener.java
##########
@@ -104,7 +104,7 @@ private MetaDataRegisterDTO buildMetaDataDTO(final ServiceBean serviceBean, fina
String path = contextPath + shenyuDubboClient.path();
String desc = shenyuDubboClient.desc();
String serviceName = serviceBean.getInterface();
- String host = StringUtils.isBlank(this.host) ? IpUtils.getHost() : this.host;
+ String host = IpUtils.getHost(this.host);
Review comment:
Latest push：
Added method to verify 'host' is a complete network host, and getHost() adds wildcard matching.
'?' only can match one, '*' can match one and more.
for example:
(192.168.* or 192.168) can match (192.168.10.166,192.168.50.32).
(192.168.10.?) can match 192.168.10.166.
(192.168.10.166) only can match 192.168.10.166
##########
File path: shenyu-client/shenyu-client-dubbo/shenyu-client-apache-dubbo/src/main/java/org/apache/shenyu/client/apache/dubbo/ApacheDubboServiceBeanListener.java
##########
@@ -104,7 +104,7 @@ private MetaDataRegisterDTO buildMetaDataDTO(final ServiceBean serviceBean, fina
String path = contextPath + shenyuDubboClient.path();
String desc = shenyuDubboClient.desc();
String serviceName = serviceBean.getInterface();
- String host = StringUtils.isBlank(this.host) ? IpUtils.getHost() : this.host;
+ String host = IpUtils.getHost(this.host);
Review comment:
Latest push：
Added method to verify 'host' is a complete network host, and getHost() adds wildcard matching.
'?' only can match one, '\*' can match one and more.
for example:
(192.168.* or 192.168) can match (192.168.10.166,192.168.50.32).
(192.168.10.?) can match 192.168.10.166.
(192.168.10.166) only can match 192.168.10.166
##########
File path: shenyu-client/shenyu-client-dubbo/shenyu-client-apache-dubbo/src/main/java/org/apache/shenyu/client/apache/dubbo/ApacheDubboServiceBeanListener.java
##########
@@ -104,7 +104,7 @@ private MetaDataRegisterDTO buildMetaDataDTO(final ServiceBean serviceBean, fina
String path = contextPath + shenyuDubboClient.path();
String desc = shenyuDubboClient.desc();
String serviceName = serviceBean.getInterface();
- String host = StringUtils.isBlank(this.host) ? IpUtils.getHost() : this.host;
+ String host = IpUtils.getHost(this.host);
Review comment:
Latest push：
Added method to verify 'host' is a complete network host, and getHost() adds wildcard matching.
'?' only can match one, '\*' can match one and more.
for example:
(192.168.* or 192.168) can match (192.168.10.166,192.168.50.32).
(192.168.10.? or 192.168.10) can match 192.168.10.166.
(192.168.10.166) only can match 192.168.10.166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 removed a comment on pull request #1656: feature IpUtils: Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
yu199195 removed a comment on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864919627
see this : https://github.com/apache/incubator-shenyu/issues/160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 merged pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
yu199195 merged pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] MarsOu1995 commented on a change in pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
MarsOu1995 commented on a change in pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#discussion_r655488891
##########
File path: shenyu-client/shenyu-client-dubbo/shenyu-client-apache-dubbo/src/main/java/org/apache/shenyu/client/apache/dubbo/ApacheDubboServiceBeanListener.java
##########
@@ -104,7 +104,7 @@ private MetaDataRegisterDTO buildMetaDataDTO(final ServiceBean serviceBean, fina
String path = contextPath + shenyuDubboClient.path();
String desc = shenyuDubboClient.desc();
String serviceName = serviceBean.getInterface();
- String host = StringUtils.isBlank(this.host) ? IpUtils.getHost() : this.host;
+ String host = IpUtils.getHost(this.host);
Review comment:
If'host' is empty, then get the first ip. If it is an incomplete ip, the first suitable one will be matched.
If your input is complete, this is the one you get. After all, you are unlikely to have two IPs on the same network segment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] MarsOu1995 commented on a change in pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
MarsOu1995 commented on a change in pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#discussion_r655584491
##########
File path: shenyu-client/shenyu-client-dubbo/shenyu-client-apache-dubbo/src/main/java/org/apache/shenyu/client/apache/dubbo/ApacheDubboServiceBeanListener.java
##########
@@ -104,7 +104,7 @@ private MetaDataRegisterDTO buildMetaDataDTO(final ServiceBean serviceBean, fina
String path = contextPath + shenyuDubboClient.path();
String desc = shenyuDubboClient.desc();
String serviceName = serviceBean.getInterface();
- String host = StringUtils.isBlank(this.host) ? IpUtils.getHost() : this.host;
+ String host = IpUtils.getHost(this.host);
Review comment:
Latest push：
Added method to verify 'host' is a complete network host, and getHost() adds wildcard matching.
'?' only can match one, '\*' can match one and more.
for example:
(192.168.* or 192.168) can match (192.168.10.166,192.168.50.32).
(192.168.10.? or 192.168.10) can match 192.168.10.166.
(192.168.10.166) only can match 192.168.10.166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] MarsOu1995 commented on a change in pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
MarsOu1995 commented on a change in pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#discussion_r655483858
##########
File path: shenyu-common/src/main/java/org/apache/shenyu/common/utils/IpUtils.java
##########
@@ -44,11 +56,25 @@ public static String getHost() {
InetAddress inetAddress = (InetAddress) addresses.nextElement();
String hostAddress = inetAddress.getHostAddress();
if (hostAddress.contains(".") && !inetAddress.isLoopbackAddress()) {
- hostIp = hostAddress;
- break;
+ if (first) {
+ firstHostIp = hostAddress;
+ first = false;
Review comment:
Yes it would be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] MarsOu1995 commented on pull request #1656: feature IpUtils: Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
MarsOu1995 commented on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864916788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #1656: feature IpUtils: Multi-network environment optimization.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864549493
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1656](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (62d2fba) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/cb452662429a641eda65605f8524cbe284b2f7e1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb45266) will **decrease** coverage by `1.35%`.
> The diff coverage is `52.94%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1656 +/- ##
============================================
- Coverage 63.38% 62.02% -1.36%
+ Complexity 2249 2214 -35
============================================
Files 460 460
Lines 9659 9556 -103
Branches 976 975 -1
============================================
- Hits 6122 5927 -195
- Misses 3042 3135 +93
+ Partials 495 494 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...alibaba/dubbo/AlibabaDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9hbGliYWJhL2R1YmJvL0FsaWJhYmFEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...t/apache/dubbo/ApacheDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvY2xpZW50L2FwYWNoZS9kdWJiby9BcGFjaGVEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ient/springcloud/init/ContextRegisterListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L0NvbnRleHRSZWdpc3Rlckxpc3RlbmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `35.13% <0.00%> (-55.54%)` | :arrow_down: |
| [...n/java/org/apache/shenyu/common/utils/IpUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9JcFV0aWxzLmphdmE=) | `75.00% <72.72%> (+1.31%)` | :arrow_up: |
| [...cloud/init/SpringCloudClientBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L1NwcmluZ0Nsb3VkQ2xpZW50QmVhblBvc3RQcm9jZXNzb3IuamF2YQ==) | `77.04% <100.00%> (+1.63%)` | :arrow_up: |
| [...ache/shenyu/admin/exception/ExceptionHandlers.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZXhjZXB0aW9uL0V4Y2VwdGlvbkhhbmRsZXJzLmphdmE=) | `30.55% <0.00%> (-42.78%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `72.22% <0.00%> (-22.23%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `63.10% <0.00%> (-11.66%)` | :arrow_down: |
| ... and [31 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb45266...62d2fba](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864549493
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1656](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d01db8) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/cb452662429a641eda65605f8524cbe284b2f7e1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb45266) will **decrease** coverage by `0.63%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1656 +/- ##
============================================
- Coverage 63.38% 62.74% -0.64%
+ Complexity 2249 2223 -26
============================================
Files 460 460
Lines 9659 9558 -101
Branches 976 976
============================================
- Hits 6122 5997 -125
- Misses 3042 3065 +23
- Partials 495 496 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...alibaba/dubbo/AlibabaDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9hbGliYWJhL2R1YmJvL0FsaWJhYmFEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...t/apache/dubbo/ApacheDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvY2xpZW50L2FwYWNoZS9kdWJiby9BcGFjaGVEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ient/springcloud/init/ContextRegisterListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L0NvbnRleHRSZWdpc3Rlckxpc3RlbmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/shenyu/common/utils/IpUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9JcFV0aWxzLmphdmE=) | `70.00% <61.53%> (-3.69%)` | :arrow_down: |
| [...cloud/init/SpringCloudClientBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L1NwcmluZ0Nsb3VkQ2xpZW50QmVhblBvc3RQcm9jZXNzb3IuamF2YQ==) | `77.04% <100.00%> (+1.63%)` | :arrow_up: |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `91.89% <100.00%> (+1.22%)` | :arrow_up: |
| [...ache/shenyu/admin/exception/ExceptionHandlers.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZXhjZXB0aW9uL0V4Y2VwdGlvbkhhbmRsZXJzLmphdmE=) | `30.55% <0.00%> (-42.78%)` | :arrow_down: |
| [.../admin/service/impl/DataPermissionServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL0RhdGFQZXJtaXNzaW9uU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (-6.85%)` | :arrow_down: |
| [...enyu/admin/service/impl/PermissionServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Blcm1pc3Npb25TZXJ2aWNlSW1wbC5qYXZh) | `54.54% <0.00%> (-5.99%)` | :arrow_down: |
| [...apache/shenyu/admin/controller/RoleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9Sb2xlQ29udHJvbGxlci5qYXZh) | `84.61% <0.00%> (-4.28%)` | :arrow_down: |
| ... and [25 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb45266...5d01db8](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] MarsOu1995 commented on a change in pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
MarsOu1995 commented on a change in pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#discussion_r655508749
##########
File path: shenyu-client/shenyu-client-dubbo/shenyu-client-apache-dubbo/src/main/java/org/apache/shenyu/client/apache/dubbo/ApacheDubboServiceBeanListener.java
##########
@@ -104,7 +104,7 @@ private MetaDataRegisterDTO buildMetaDataDTO(final ServiceBean serviceBean, fina
String path = contextPath + shenyuDubboClient.path();
String desc = shenyuDubboClient.desc();
String serviceName = serviceBean.getInterface();
- String host = StringUtils.isBlank(this.host) ? IpUtils.getHost() : this.host;
+ String host = IpUtils.getHost(this.host);
Review comment:
Or we can optimize the internal implementation of the method.
Distinguish the use of 'startwith' or 'equals'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 commented on pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
yu199195 commented on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-867482301
@dengliming can merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 commented on pull request #1656: feature IpUtils: Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
yu199195 commented on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864934084
see this : https://github.com/apache/incubator-shenyu/issues/1601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864549493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] dengliming commented on a change in pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
dengliming commented on a change in pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#discussion_r655436490
##########
File path: shenyu-common/src/main/java/org/apache/shenyu/common/utils/IpUtils.java
##########
@@ -34,6 +34,18 @@ private IpUtils() {
* @return the host
*/
public static String getHost() {
+ return getHost(null);
+ }
+
+ /**
+ * Gets host.
+ *
+ * @param preferred host preferred str
+ * @return the host
+ */
+ public static String getHost(final String preferred) {
Review comment:
`getHost(final String filterPrefix)` maybe better.
##########
File path: shenyu-common/src/main/java/org/apache/shenyu/common/utils/IpUtils.java
##########
@@ -44,11 +56,25 @@ public static String getHost() {
InetAddress inetAddress = (InetAddress) addresses.nextElement();
String hostAddress = inetAddress.getHostAddress();
if (hostAddress.contains(".") && !inetAddress.isLoopbackAddress()) {
- hostIp = hostAddress;
- break;
+ if (first) {
+ firstHostIp = hostAddress;
+ first = false;
Review comment:
You don't need to check `first`.
```
if (firstHostIp == null) {
firstHostIp = hostAddress;
}
```
##########
File path: shenyu-client/shenyu-client-dubbo/shenyu-client-apache-dubbo/src/main/java/org/apache/shenyu/client/apache/dubbo/ApacheDubboServiceBeanListener.java
##########
@@ -104,7 +104,7 @@ private MetaDataRegisterDTO buildMetaDataDTO(final ServiceBean serviceBean, fina
String path = contextPath + shenyuDubboClient.path();
String desc = shenyuDubboClient.desc();
String serviceName = serviceBean.getInterface();
- String host = StringUtils.isBlank(this.host) ? IpUtils.getHost() : this.host;
+ String host = IpUtils.getHost(this.host);
Review comment:
I think it would be better if `host` and `hostPrefix` were configured separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] MarsOu1995 commented on pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
MarsOu1995 commented on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864936678
Oh, the title is not right yet.-.-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 commented on pull request #1656: feature IpUtils: Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
yu199195 commented on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864919627
see this : https://github.com/apache/incubator-shenyu/issues/160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1656: feature IpUtils: Multi-network environment optimization.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864549493
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1656](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (62d2fba) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/cb452662429a641eda65605f8524cbe284b2f7e1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb45266) will **decrease** coverage by `0.88%`.
> The diff coverage is `52.94%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1656 +/- ##
============================================
- Coverage 63.38% 62.49% -0.89%
+ Complexity 2249 2221 -28
============================================
Files 460 460
Lines 9659 9556 -103
Branches 976 975 -1
============================================
- Hits 6122 5972 -150
- Misses 3042 3088 +46
- Partials 495 496 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...alibaba/dubbo/AlibabaDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9hbGliYWJhL2R1YmJvL0FsaWJhYmFEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...t/apache/dubbo/ApacheDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvY2xpZW50L2FwYWNoZS9kdWJiby9BcGFjaGVEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ient/springcloud/init/ContextRegisterListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L0NvbnRleHRSZWdpc3Rlckxpc3RlbmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `59.45% <0.00%> (-31.21%)` | :arrow_down: |
| [...n/java/org/apache/shenyu/common/utils/IpUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9JcFV0aWxzLmphdmE=) | `75.00% <72.72%> (+1.31%)` | :arrow_up: |
| [...cloud/init/SpringCloudClientBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L1NwcmluZ0Nsb3VkQ2xpZW50QmVhblBvc3RQcm9jZXNzb3IuamF2YQ==) | `77.04% <100.00%> (+1.63%)` | :arrow_up: |
| [...ache/shenyu/admin/exception/ExceptionHandlers.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZXhjZXB0aW9uL0V4Y2VwdGlvbkhhbmRsZXJzLmphdmE=) | `30.55% <0.00%> (-42.78%)` | :arrow_down: |
| [.../admin/service/impl/DataPermissionServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL0RhdGFQZXJtaXNzaW9uU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (-6.85%)` | :arrow_down: |
| [...enyu/admin/service/impl/PermissionServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Blcm1pc3Npb25TZXJ2aWNlSW1wbC5qYXZh) | `54.54% <0.00%> (-5.99%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb45266...62d2fba](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 commented on pull request #1656: feature IpUtils: Multi-network environment optimization.
Posted by GitBox <gi...@apache.org>.
yu199195 commented on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864913811
please modify this tilte
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1656: feature shenyu-common: IpUtils Add parameters to select the network ip .
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1656:
URL: https://github.com/apache/incubator-shenyu/pull/1656#issuecomment-864549493
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1656](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2d52006) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/cb452662429a641eda65605f8524cbe284b2f7e1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb45266) will **decrease** coverage by `1.07%`.
> The diff coverage is `47.36%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1656 +/- ##
============================================
- Coverage 63.38% 62.30% -1.08%
+ Complexity 2249 2217 -32
============================================
Files 460 460
Lines 9659 9558 -101
Branches 976 976
============================================
- Hits 6122 5955 -167
- Misses 3042 3110 +68
+ Partials 495 493 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...alibaba/dubbo/AlibabaDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9hbGliYWJhL2R1YmJvL0FsaWJhYmFEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...t/apache/dubbo/ApacheDubboServiceBeanListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvY2xpZW50L2FwYWNoZS9kdWJiby9BcGFjaGVEdWJib1NlcnZpY2VCZWFuTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ient/springcloud/init/ContextRegisterListener.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L0NvbnRleHRSZWdpc3Rlckxpc3RlbmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `58.10% <0.00%> (-32.56%)` | :arrow_down: |
| [...n/java/org/apache/shenyu/common/utils/IpUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9JcFV0aWxzLmphdmE=) | `70.00% <61.53%> (-3.69%)` | :arrow_down: |
| [...cloud/init/SpringCloudClientBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWh0dHAvc2hlbnl1LWNsaWVudC1zcHJpbmdjbG91ZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9zcHJpbmdjbG91ZC9pbml0L1NwcmluZ0Nsb3VkQ2xpZW50QmVhblBvc3RQcm9jZXNzb3IuamF2YQ==) | `77.04% <100.00%> (+1.63%)` | :arrow_up: |
| [...ache/shenyu/admin/exception/ExceptionHandlers.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vZXhjZXB0aW9uL0V4Y2VwdGlvbkhhbmRsZXJzLmphdmE=) | `30.55% <0.00%> (-42.78%)` | :arrow_down: |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `77.77% <0.00%> (-16.67%)` | :arrow_down: |
| [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `54.73% <0.00%> (-9.48%)` | :arrow_down: |
| ... and [30 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1656/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb45266...2d52006](https://codecov.io/gh/apache/incubator-shenyu/pull/1656?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org