You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2020/11/14 18:27:13 UTC
svn commit: r1883428 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDButton.java
Author: msahyoun
Date: Sat Nov 14 18:27:12 2020
New Revision: 1883428
URL: http://svn.apache.org/viewvc?rev=1883428&view=rev
Log:
PDFBOX-4892: sonar fixes; limit visibility of abstract class
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDButton.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDButton.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDButton.java?rev=1883428&r1=1883427&r2=1883428&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDButton.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDButton.java Sat Nov 14 18:27:12 2020
@@ -61,7 +61,7 @@ public abstract class PDButton extends P
*
* @param acroForm The acroform.
*/
- public PDButton(PDAcroForm acroForm)
+ PDButton(PDAcroForm acroForm)
{
super(acroForm);
getCOSObject().setItem(COSName.FT, COSName.BTN);
@@ -114,7 +114,7 @@ public abstract class PDButton extends P
{
String stringValue = ((COSName)value).getName();
List<String> exportValues = getExportValues();
- if (exportValues.size() > 0)
+ if (!exportValues.isEmpty())
{
try
{
@@ -153,9 +153,7 @@ public abstract class PDButton extends P
// if there are export values/an Opt entry there is a different
// approach to setting the value
- boolean hasExportValues = getExportValues().size() > 0;
-
- if (hasExportValues) {
+ if (!getExportValues().isEmpty()) {
updateByOption(value);
}
else
@@ -286,7 +284,7 @@ public abstract class PDButton extends P
void constructAppearances() throws IOException
{
List<String> exportValues = getExportValues();
- if (exportValues.size() > 0)
+ if (!exportValues.isEmpty())
{
// the value is the index value of the option. So we need to get that
// and use it to set the value
@@ -324,7 +322,7 @@ public abstract class PDButton extends P
// we need a set as the field can appear multiple times
Set<String> onValues = new LinkedHashSet<>();
- if (getExportValues().size() > 0)
+ if (!getExportValues().isEmpty())
{
onValues.addAll(getExportValues());
return onValues;