You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/06 22:53:53 UTC

[GitHub] [spark] c21 commented on a change in pull request #34501: [SPARK-37223][SQL][TESTS] Fix unit test check in JoinHintSuite

c21 commented on a change in pull request #34501:
URL: https://github.com/apache/spark/pull/34501#discussion_r744177153



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala
##########
@@ -612,8 +612,8 @@ class JoinHintSuite extends PlanTest with SharedSparkSession with AdaptiveSparkP
 
         val logs = hintAppender.loggingEvents.map(_.getRenderedMessage)
           .filter(_.contains("is not supported in the query:"))
-        assert(logs.size == 2)
-        logs.forall(_.contains(s"build left for ${joinType.split("_").mkString(" ")} join."))
+        assert(logs.size == 2 &&
+          logs.forall(_.contains(s"build left for ${joinType.split("_").mkString(" ")} join.")))

Review comment:
       @srowen, @advancedxy - updated, thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org