You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/14 17:03:05 UTC

[GitHub] [tvm] rkimball commented on a change in pull request #7766: Replace 0.0.0.0 with 127.0.0.1 for client connections

rkimball commented on a change in pull request #7766:
URL: https://github.com/apache/tvm/pull/7766#discussion_r613423618



##########
File path: python/tvm/rpc/proxy.py
##########
@@ -512,7 +512,7 @@ def __init__(
                 self.port = my_port
                 break
             except socket.error as sock_err:
-                if sock_err.errno in [98, 48]:
+                if sock_err.errno in [98, 48, 10098, 10048]:

Review comment:
       98/10098 is errno.EADDRINUSE for linux/windows. This works for both.
   48 is errno.ELNRNG on linux but ELNRNG is not defined in windows so we can't use the symbol. The error translates to `Link number out of range` which I don't understand. I removed 48/10048. If we want we can add the number 48 back but we can't use the symbol.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org