You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2016/06/20 01:44:45 UTC

svn commit: r1749246 - /poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetShiftRows.java

Author: onealj
Date: Mon Jun 20 01:44:44 2016
New Revision: 1749246

URL: http://svn.apache.org/viewvc?rev=1749246&view=rev
Log:
bug 56454: add disabled unit test based on J�rg Selbach's test case showing shiftRows incorrectly handles merged regions

Modified:
    poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetShiftRows.java

Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetShiftRows.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetShiftRows.java?rev=1749246&r1=1749245&r2=1749246&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetShiftRows.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestSheetShiftRows.java Mon Jun 20 01:44:44 2016
@@ -602,6 +602,39 @@ public abstract class BaseTestSheetShift
         read.close();
     }
     
+    // bug 56454
+    @Ignore
+    @Test
+    public void shiftRowsWithMergedRegionsThatDoNotContainColumnZero() throws IOException {
+        Workbook wb = _testDataProvider.createWorkbook();
+        Sheet sheet = wb.createSheet("test");
+        
+        // populate sheet cells
+        for (int i = 0; i < 10; i++) {
+            Row row = sheet.createRow(i);
+            for (int j = 0; j < 12; j++) {
+                Cell cell = row.createCell(j);
+                cell.setCellValue(i + "x" + j);
+            }
+        }
+
+        CellRangeAddress A4_B7 = new CellRangeAddress(3, 6, 0, 1);
+        CellRangeAddress C5_D7 = new CellRangeAddress(4, 6, 2, 3);
+
+        sheet.addMergedRegion(A4_B7);
+        sheet.addMergedRegion(C5_D7);
+
+        // A4:B7 will elongate vertically
+        // C5:D7 will be shifted down with same size
+        sheet.shiftRows(4, sheet.getLastRowNum(), 1);
+
+        assertEquals(2, sheet.getNumMergedRegions());
+        assertEquals(CellRangeAddress.valueOf("A4:B8"), sheet.getMergedRegion(0));
+        assertEquals(CellRangeAddress.valueOf("C5:D8"), sheet.getMergedRegion(1));
+        
+        wb.close();
+    }
+    
     private void createHyperlink(CreationHelper helper, Cell cell, int linkType, String ref) {
         cell.setCellValue(ref);
         Hyperlink link = helper.createHyperlink(linkType);



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org