You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/09/03 10:38:36 UTC

[GitHub] [activemq-artemis] gemmellr opened a new pull request #3723: NO-JIRA: undo addition of module-specific resources-plugin version

gemmellr opened a new pull request #3723:
URL: https://github.com/apache/activemq-artemis/pull/3723


   Commit 97e84bb0d12cd2ce51571032ec3a946a97e6589d added in some explicit uses of the maven-resources plugin, and specifically configured use of version 2.6 for these. The build is otherwise already using version 3.1.0 of the resources-plugin, via pluginManagement from the apache parent pom. Its not clear the specific older version was needed, so this would remove it and keep the version config consistent and consolidated in the parents.
   
   @brusdev ^
   
   (Original change should probably have a JIRA that this could have gone against also)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3723: NO-JIRA: undo addition of module-specific resources-plugin version

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3723:
URL: https://github.com/apache/activemq-artemis/pull/3723#issuecomment-912649570


   thanks as usual @gemmellr 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic merged pull request #3723: NO-JIRA: undo addition of module-specific resources-plugin version

Posted by GitBox <gi...@apache.org>.
clebertsuconic merged pull request #3723:
URL: https://github.com/apache/activemq-artemis/pull/3723


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr edited a comment on pull request #3723: NO-JIRA: undo addition of module-specific resources-plugin version

Posted by GitBox <gi...@apache.org>.
gemmellr edited a comment on pull request #3723:
URL: https://github.com/apache/activemq-artemis/pull/3723#issuecomment-912469139


   Also fixes the build warnings introduced from having multiple version definitions, e.g:
   > [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-resources-plugin @ line 572, column 18
   
   Err, didnt mean to post that until I updated it so it did, lol


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #3723: NO-JIRA: undo addition of module-specific resources-plugin version

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3723:
URL: https://github.com/apache/activemq-artemis/pull/3723#issuecomment-912469139


   Also fixes the build warnings introduced from having multiple version definitions, e.g:
   > [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-resources-plugin @ line 572, column 18


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #3723: NO-JIRA: undo addition of module-specific resources-plugin version

Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3723:
URL: https://github.com/apache/activemq-artemis/pull/3723#issuecomment-912480331


   So yeah, _now_ it should hopefully also fix the build warning :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org