You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2016/09/09 07:42:13 UTC

[GitHub] brooklyn-server pull request #279: Allow provisioning.properties to referenc...

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/279#discussion_r78140278
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java ---
    @@ -603,21 +607,37 @@ public MachineLocation obtain(Map<?,?> flags, TemplateBuilder tb) throws NoMachi
             return obtain(MutableMap.builder().putAll(flags).put(TEMPLATE_BUILDER, tb).build());
         }
     
    -    /** core method for obtaining a VM using jclouds;
    +    private ConfigBag getConfigBag(Map<?, ?> flags) {
    --- End diff --
    
    call this `getConfigBagExtendedWithFlagsResolved` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---