You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (Created) (JIRA)" <ji...@apache.org> on 2012/03/19 12:31:38 UTC
[jira] [Created] (BOOKKEEPER-187) Create well defined interface for
LedgerCache
Create well defined interface for LedgerCache
---------------------------------------------
Key: BOOKKEEPER-187
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-187
Project: Bookkeeper
Issue Type: Sub-task
Reporter: Ivan Kelly
Assignee: Ivan Kelly
Fix For: 4.1.0
Currently the code reaches into LedgerCache to access FileInfos or read what is in the cache without going through clean interfaces. This JIRA is to define an interface for LedgerCache, so that we can reason about what accesses are legal.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-187) Create well defined interface
for LedgerCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232569#comment-13232569 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-187:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4403/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
Patch creates LedgerCache interface, and LedgerCacheImpl, which implements the interface. LedgerCacheImpl's contains what LedgerCache did before the change. LedgerDescriptor uses LedgerCacheImpl directly now, which is ugly, but its only temporary as BOOKKEEPER-175 will fix LedgerDescriptors.
This addresses bug BOOKKEEPER-187.
https://issues.apache.org/jira/browse/BOOKKEEPER-187
Diffs
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 6e47c08
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java c514f6d
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java ba9c6d4
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheBean.java d14f373
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java 87a1e66
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalTest.java 6e64932
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/UpgradeTest.java c4eacda
Diff: https://reviews.apache.org/r/4403/diff
Testing
-------
Thanks,
Ivan
> Create well defined interface for LedgerCache
> ---------------------------------------------
>
> Key: BOOKKEEPER-187
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-187
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-187.diff
>
>
> Currently the code reaches into LedgerCache to access FileInfos or read what is in the cache without going through clean interfaces. This JIRA is to define an interface for LedgerCache, so that we can reason about what accesses are legal.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-187) Create well defined interface
for LedgerCache
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233872#comment-13233872 ]
Hudson commented on BOOKKEEPER-187:
-----------------------------------
Integrated in bookkeeper-trunk #419 (See [https://builds.apache.org/job/bookkeeper-trunk/419/])
BOOKKEEPER-187: Create well defined interface for LedgerCache (ivank) (Revision 1302851)
Result = ABORTED
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheBean.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalTest.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/UpgradeTest.java
> Create well defined interface for LedgerCache
> ---------------------------------------------
>
> Key: BOOKKEEPER-187
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-187
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-187.diff
>
>
> Currently the code reaches into LedgerCache to access FileInfos or read what is in the cache without going through clean interfaces. This JIRA is to define an interface for LedgerCache, so that we can reason about what accesses are legal.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-187) Create well defined interface
for LedgerCache
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233262#comment-13233262 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-187:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4403/#review6112
-----------------------------------------------------------
Ship it!
the patch looks good to me. +1.
- Sijie
On 2012-03-19 11:37:21, Ivan Kelly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4403/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-19 11:37:21)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Patch creates LedgerCache interface, and LedgerCacheImpl, which implements the interface. LedgerCacheImpl's contains what LedgerCache did before the change. LedgerDescriptor uses LedgerCacheImpl directly now, which is ugly, but its only temporary as BOOKKEEPER-175 will fix LedgerDescriptors.
bq.
bq.
bq. This addresses bug BOOKKEEPER-187.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-187
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 6e47c08
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java c514f6d
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCache.java ba9c6d4
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheBean.java d14f373
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java PRE-CREATION
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptor.java 87a1e66
bq. bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalTest.java 6e64932
bq. bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/UpgradeTest.java c4eacda
bq.
bq. Diff: https://reviews.apache.org/r/4403/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ivan
bq.
bq.
> Create well defined interface for LedgerCache
> ---------------------------------------------
>
> Key: BOOKKEEPER-187
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-187
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-187.diff
>
>
> Currently the code reaches into LedgerCache to access FileInfos or read what is in the cache without going through clean interfaces. This JIRA is to define an interface for LedgerCache, so that we can reason about what accesses are legal.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-187) Create well defined interface for
LedgerCache
Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-187:
----------------------------------
Attachment: BOOKKEEPER-187.diff
Patch creates LedgerCache interface, and LedgerCacheImpl, which implements the interface. LedgerCacheImpl's contains what LedgerCache did before the change. LedgerDescriptor uses LedgerCacheImpl directly now, which is ugly, but its only temporary as BOOKKEEPER-175 will fix LedgerDescriptors.
> Create well defined interface for LedgerCache
> ---------------------------------------------
>
> Key: BOOKKEEPER-187
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-187
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-187.diff
>
>
> Currently the code reaches into LedgerCache to access FileInfos or read what is in the cache without going through clean interfaces. This JIRA is to define an interface for LedgerCache, so that we can reason about what accesses are legal.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira