You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2023/06/28 23:21:05 UTC

[pinot] branch master updated: do not readd lucene readers to queue if segment is destroyed (#10989)

This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 5c3cf01cd8 do not readd lucene readers to queue if segment is destroyed (#10989)
5c3cf01cd8 is described below

commit 5c3cf01cd8b092c6e385b6a6f3427de6f54b724d
Author: Christopher Peck <27...@users.noreply.github.com>
AuthorDate: Wed Jun 28 16:20:59 2023 -0700

    do not readd lucene readers to queue if segment is destroyed (#10989)
---
 .../impl/invertedindex/RealtimeLuceneIndexReaderRefreshThread.java    | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneIndexReaderRefreshThread.java b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneIndexReaderRefreshThread.java
index a352f37428..13110b4f32 100644
--- a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneIndexReaderRefreshThread.java
+++ b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneIndexReaderRefreshThread.java
@@ -135,7 +135,9 @@ public class RealtimeLuceneIndexReaderRefreshThread implements Runnable {
             }
           }
         } finally {
-          _luceneRealtimeReaders.offer(realtimeReadersForSegment);
+          if (!realtimeReadersForSegment.isSegmentDestroyed()) {
+            _luceneRealtimeReaders.offer(realtimeReadersForSegment);
+          }
           realtimeReadersForSegment.getLock().unlock();
         }
       }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org