[GitHub] [incubator-devlake] e2corporation commented on issue #2155: [Bug] [config-ui] Only trigger connection test when multi tokens

[GitBox <gi...@apache.org>]

e2corporation commented on issue #2155:
URL: https://github.com/apache/incubator-devlake/issues/2155#issuecomment-1154063658

   @klesh @likyh We'll need more clarity on this. There was a feature request already added that if user has multiple tokens on a GitHub or JIRA type connection that a test connection should be run to  identify if one of those tokens may not be valid, in which case we want an error to be raised.
   
   What is the exact issue? It appears that the backend should understand that this value is a multi-token string and act accordingly (previously the error shown indicated a bad token). Or does UI need to send the multi-token value as an array and not string? We'll have to inspect the request payload to see what is being sent. If you were saving a connection where both tokens were valid, ideally no error would have been raised and the connection would have been saved.
   
   Here is the original PR to add test connection for a multi-token provider.
   https://github.com/apache/incubator-devlake/pull/1777


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org