You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/18 14:08:10 UTC
[GitHub] [incubator-dolphinscheduler] runningdata opened a new pull request
#1519: return result state for each interface method
runningdata opened a new pull request #1519: return result state for each interface method
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1519
Queue operation should has the result state
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1519:
return result state for each interface method
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #1519: return result state for each interface method
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1519#issuecomment-571528192
as Tboy said, it's seemly no sense. this pr will close.
thanks for your first contribution, if you have interesting in developing DS, you can contact my mail: dailidong66@gmail.com or wechat: 510570367, when contacted , please tell me your github id, that I can easily recognize you.
Best regards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong closed pull request #1519:
return result state for each interface method
Posted by GitBox <gi...@apache.org>.
dailidong closed pull request #1519: return result state for each interface method
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1519
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- edited a comment on issue
#1519: return result state for each interface method
Posted by GitBox <gi...@apache.org>.
Technoboy- edited a comment on issue #1519: return result state for each interface method
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1519#issuecomment-567380815
> > > > Hi, bro, thanks for contribution.
> > > > this pr looks not useful, it we add return value for these methods, we should use the return value to decide something. such as ： if add method return false, we may log or retry, but doing nothing . These methods you modify have printed the log, it's enough .
> > > > So do you agree me ?
> > >
> > >
> > > Yes, I agree. I don't know **the context**. Those who know their own context should handle this.
> > > But the interface should has the return value to indicate whether the operation is successed. All exceptions now has been passed, without any alert to interface API user.
> >
> >
> > Yes. But add return value according to executing without error or not is not accurate.
>
> FYI
I mean : return true is not accurate when executing without exception . srem or sadd may return false due to zk not has the relative value . it's like -- update in MySQL, the return value represents for the influence count.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services