[jira] [Commented] (AMBARI-20736) Allow Potentially Long Running Restart Commands To Have Their Own Timeout

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-20736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964993#comment-15964993 ] 

Hadoop QA commented on AMBARI-20736:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12862909/AMBARI-20736.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified test files.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in ambari-server:

                  org.apache.ambari.server.state.ServicePropertiesTest

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/11365//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11365//console

This message is automatically generated.

> Allow Potentially Long Running Restart Commands To Have Their Own Timeout
> -------------------------------------------------------------------------
>
>                 Key: AMBARI-20736
>                 URL: https://issues.apache.org/jira/browse/AMBARI-20736
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>            Reporter: Nate Cole
>            Assignee: Nate Cole
>            Priority: Critical
>             Fix For: 2.5.1
>
>         Attachments: AMBARI-20736.patch
>
>
> During an upgrade of a cluster, some commands are expected to take a very long time depending on what the size of the cluster is and how much data is stored. For example, a NameNode restart with SafeMode exit may take in excess of 30 minutes. On some clusters, this could take less than 1 minute.
> Currently today, the only way to adjust these properties is to do so across the board for all commands by editing {{ambari.properties}} and setting {{agent.task.timeout}}. This solution doesn't work very well since the majority of restarts during an upgrade are not on a master component.
> There needs to be a way to instruct Ambari that a restart should be allowed to run for a relatively long period of time. 
> - Both Java and Python need to be considered here. We don't want Python to give up and return a {{FAILED}} state and we don't want Ambari server to set the task to {{TIMEDOUT}}.
> - This can be useful in both normal restarts and upgrade scenarios. 
> h3. Upgrade Only
> If considering this functionality in the context of an upgrade only, then it is conceivable that this logic can be placed inside of the upgrade XML packs:
> {code}
>     <service name="HDFS">
>       <component name="NAMENODE">
>         <upgrade>
>           <task xsi:type="restart-task"  timeout="1800"/>
>         </upgrade>
> {code}
> - This would allow future mpacks to be able to control the restart of components. Perhaps this can even be slightly abstracted out:
> {code}
>     <service name="HDFS">
>       <component name="NAMENODE">
>         <upgrade>
>           <task xsi:type="restart-task"  timeout="upgrade.parameter.master.restart.long"/>
>         </upgrade>
> upgrade.parameter.slave.restart.short = 300
> upgrade.parameter.slave.restart.long = 900
> upgrade.parameter.master.restart.short = 1500
> upgrade.parameter.master.restart.long = 1800
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)