Re: [PR] [SPARK-48263] Collate function support for non UTF8_BINARY strings [spark]

["nebojsa-db (via GitHub)" <gi...@apache.org>]

nebojsa-db commented on code in PR #46574:
URL: https://github.com/apache/spark/pull/46574#discussion_r1599705816


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collationExpressions.scala:
##########
@@ -57,14 +57,14 @@ object CollateExpressionBuilder extends ExpressionBuilder {
     expressions match {
       case Seq(e: Expression, collationExpr: Expression) =>
         (collationExpr.dataType, collationExpr.foldable) match {
-          case (StringType, true) =>
+          case (_: StringType, true) =>

Review Comment:
   Updated the name. 
   Regarding the test, it will be added as part of https://github.com/apache/spark/pull/46561 which originally caught this issue. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org