[GitHub] [accumulo] milleruntime commented on a change in pull request #2408: Attempt to verify that MAC processes are up and running in start

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #2408:
URL: https://github.com/apache/accumulo/pull/2408#discussion_r778370416



##########
File path: minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloClusterImpl.java
##########
@@ -600,6 +602,97 @@ public synchronized void start() throws IOException, InterruptedException {
     if (executor == null) {
       executor = Executors.newSingleThreadExecutor();
     }
+
+    verifyUp();
+
+  }
+
+  private void verifyUp() throws InterruptedException, IOException {

Review comment:
       It might be useful to make this public (and available outside of the impl) so tests can use it as well. I am pretty sure there are a few tests doing this already, maybe this could replace duplicate code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org