You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "samueleresca (via GitHub)" <gi...@apache.org> on 2024/02/28 10:26:35 UTC
[PR] Overriding source.st excluding the data-md-source attribute. [incubator-pekko-sbt-paradox]
samueleresca opened a new pull request, #121:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/121
Removing data-md-source to avoid external 3rd party calls to GH.
See: #110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Overriding source.st excluding the data-md-source attribute. [incubator-pekko-sbt-paradox]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #121:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/121#issuecomment-1968994501
I tried this out on my laptop and it seems to work well. The GitHub link appears but we don't seem to get the api.github.com calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Overriding source.st excluding the data-md-source attribute. [incubator-pekko-sbt-paradox]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #121:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/121#discussion_r1505725375
##########
theme/src/main/assets/partials/source.st:
##########
@@ -0,0 +1,35 @@
+$!
+ Copyright (c) 2016-2018 Martin Donath <ma...@squidfunk.com>
+ Copyright (c) 2017-2018 Jonas Fonseca <jo...@gmail.com>
+
+ Permission is hereby granted, free of charge, to any person obtaining a copy
+ of this software and associated documentation files (the "Software"), to
+ deal in the Software without restriction, including without limitation the
+ rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ sell copies of the Software, and to permit persons to whom the Software is
+ furnished to do so, subject to the following conditions:
+
+ The above copyright notice and this permission notice shall be included in
+ all copies or substantial portions of the Software.
+
+ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
+ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ IN THE SOFTWARE.
+!$
+<!-- Adapted from sbt-paradox-material-theme version 0.6.0 -->
+<!-- https://github.com/sbt/sbt-paradox-material-theme/blob/2d57fe0567ea9fe7e8de14faef4fa777841d505a/theme/src/main/assets/partials/source.st -->
+<!-- It removes the data-md-source attribute so that we don't perform any 3rd party request to GH -->
+<a href="$page.properties.("material.repo")$"
+ title="Go to repository"
+ class="md-source">
+ <div class="md-source__icon">
+ <i class="fa fa-$page.properties.("material.repo.type")$"></i>
+ </div>
+ <div class="md-source__repository">
+ $page.properties.("material.repo.name"); null="'material.repo.name' not defined"$
+ </div>
+</a>
Review Comment:
2 minor issues:
* could you add a line end at the end of the file?
* could you update the LICENSE file to mention this new file? - it mentions other files that have the same origin as this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Overriding source.st excluding the data-md-source attribute. [incubator-pekko-sbt-paradox]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on code in PR #121:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/121#discussion_r1505782599
##########
theme/src/main/assets/partials/source.st:
##########
@@ -0,0 +1,35 @@
+$!
+ Copyright (c) 2016-2018 Martin Donath <ma...@squidfunk.com>
+ Copyright (c) 2017-2018 Jonas Fonseca <jo...@gmail.com>
+
+ Permission is hereby granted, free of charge, to any person obtaining a copy
+ of this software and associated documentation files (the "Software"), to
+ deal in the Software without restriction, including without limitation the
+ rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+ sell copies of the Software, and to permit persons to whom the Software is
+ furnished to do so, subject to the following conditions:
+
+ The above copyright notice and this permission notice shall be included in
+ all copies or substantial portions of the Software.
+
+ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
+ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ IN THE SOFTWARE.
+!$
+<!-- Adapted from sbt-paradox-material-theme version 0.6.0 -->
+<!-- https://github.com/sbt/sbt-paradox-material-theme/blob/2d57fe0567ea9fe7e8de14faef4fa777841d505a/theme/src/main/assets/partials/source.st -->
+<!-- It removes the data-md-source attribute so that we don't perform any 3rd party request to GH -->
+<a href="$page.properties.("material.repo")$"
+ title="Go to repository"
+ class="md-source">
+ <div class="md-source__icon">
+ <i class="fa fa-$page.properties.("material.repo.type")$"></i>
+ </div>
+ <div class="md-source__repository">
+ $page.properties.("material.repo.name"); null="'material.repo.name' not defined"$
+ </div>
+</a>
Review Comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Overriding source.st excluding the data-md-source attribute. [incubator-pekko-sbt-paradox]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca merged PR #121:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org