You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/02/02 20:04:55 UTC
[GitHub] [superset] justinpark opened a new pull request, #22968: fix(sqllab): Invalid schema fetch by deprecated value
justinpark opened a new pull request, #22968:
URL: https://github.com/apache/superset/pull/22968
### SUMMARY
Alternative solution of #22695 (reverted due to regression)
When a selected schema option in a old saved tab has been deprecated, it would fail to query since the selected schema is no longer existed.
This commit adds the validation logic for the current selected schema option and then reset the schema option if no longer existed.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After: Schema option changes from None -> Empty (Initial selected deprecated option without api fetch. And then reset the deprecated option)
https://user-images.githubusercontent.com/1392866/216437216-468645f9-734b-4c72-9ae5-b8658b8c5bb5.mov
Before:
<img width="415" alt="Screenshot_2023-01-09_at_3_55_57_PM" src="https://user-images.githubusercontent.com/1392866/211938201-af50da2a-3a5b-4fec-b479-e15e98eb2060.png">
<img width="900" alt="Superset-2" src="https://user-images.githubusercontent.com/1392866/211938150-e2d3d9a7-1566-4787-ab9e-cde8a645de16.png">
### TESTING INSTRUCTIONS
- Select a schema from the list and then close
- delete the above selected schema
- reopen the sqllab and check the error
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
cc: @ktmud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22968: fix(sqllab): Invalid schema fetch by deprecated value
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #22968:
URL: https://github.com/apache/superset/pull/22968#issuecomment-1415030027
# [Codecov](https://codecov.io/gh/apache/superset/pull/22968?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22968](https://codecov.io/gh/apache/superset/pull/22968?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4ea555a) into [master](https://codecov.io/gh/apache/superset/commit/56d4bd063c2cfe060bccea2eba180678244b194a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (56d4bd0) will **increase** coverage by `0.02%`.
> The diff coverage is `94.44%`.
```diff
@@ Coverage Diff @@
## master #22968 +/- ##
==========================================
+ Coverage 67.41% 67.43% +0.02%
==========================================
Files 1876 1878 +2
Lines 72088 72121 +33
Branches 7860 7864 +4
==========================================
+ Hits 48596 48634 +38
+ Misses 21478 21472 -6
- Partials 2014 2015 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.82% <94.44%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/hooks/apiResources/schemas.ts](https://codecov.io/gh/apache/superset/pull/22968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2hvb2tzL2FwaVJlc291cmNlcy9zY2hlbWFzLnRz) | `92.30% <92.30%> (ø)` | |
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/22968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `91.66% <93.75%> (+4.90%)` | :arrow_up: |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/22968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `79.22% <100.00%> (+1.01%)` | :arrow_up: |
| [superset-frontend/src/hooks/apiResources/tables.ts](https://codecov.io/gh/apache/superset/pull/22968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2hvb2tzL2FwaVJlc291cmNlcy90YWJsZXMudHM=) | `84.21% <100.00%> (+2.96%)` | :arrow_up: |
| [...rc/views/CRUD/data/dataset/DatasetLayout/index.tsx](https://codecov.io/gh/apache/superset/pull/22968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMYXlvdXQvaW5kZXgudHN4) | `100.00% <0.00%> (ø)` | |
| [...CRUD/data/dataset/AddDataset/EditDataset/index.tsx](https://codecov.io/gh/apache/superset/pull/22968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXQvRWRpdERhdGFzZXQvaW5kZXgudHN4) | `100.00% <0.00%> (ø)` | |
| [...s/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx](https://codecov.io/gh/apache/superset/pull/22968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXQvTGVmdFBhbmVsL2luZGV4LnRzeA==) | `78.57% <0.00%> (+1.19%)` | :arrow_up: |
| [...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx](https://codecov.io/gh/apache/superset/pull/22968?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIvaW5kZXgudHN4) | `54.79% <0.00%> (+1.36%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/superset/pull/22968?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #22968: fix(sqllab): Invalid schema fetch by deprecated value
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #22968:
URL: https://github.com/apache/superset/pull/22968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org