[jira] [Resolved] (KYLIN-3204) Potentially unclosed resources in JdbcExplorer#evalQueryMetadata

["Dong Li (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KYLIN-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dong Li resolved KYLIN-3204.
----------------------------
       Resolution: Fixed
    Fix Version/s: v2.3.0

Thanks Kaige! Patch merged with a minor refine commit:

[https://github.com/apache/kylin/commit/fee5730258a5082999bcf8d3141aa4cb179b693c]

> Potentially unclosed resources in JdbcExplorer#evalQueryMetadata
> ----------------------------------------------------------------
>
>                 Key: KYLIN-3204
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3204
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee:  Kaige Liu
>            Priority: Major
>             Fix For: v2.3.0
>
>         Attachments: KYLIN-3204-fix-potentially-unclosed-resources.patch
>
>
> {code}
>             Connection con = SqlUtil.getConnection(dbconf);
>             DatabaseMetaData dbmd = con.getMetaData();
>             ResultSet rs = dbmd.getColumns(null, tmpDatabase, tmpView, null);
> {code}
> con and rs should be closed upon return even if there is exception.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)