You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/18 03:59:36 UTC
[GitHub] [incubator-doris] zhangstar333 opened a new pull request, #9076: [Bug][Function] fix lag/lead function get invalid data
zhangstar333 opened a new pull request, #9076:
URL: https://github.com/apache/incubator-doris/pull/9076
# Proposed changes
Issue Number: close #9033
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9076: [Bug][Function] fix lag/lead function get invalid data
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9076:
URL: https://github.com/apache/incubator-doris/pull/9076#issuecomment-1107512396
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhangstar333 commented on a diff in pull request #9076: [Bug][Function] fix lag/lead function get invalid data
Posted by GitBox <gi...@apache.org>.
zhangstar333 commented on code in PR #9076:
URL: https://github.com/apache/incubator-doris/pull/9076#discussion_r851930619
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/AnalyticExpr.java:
##########
@@ -478,11 +478,13 @@ public void analyzeImpl(Analyzer analyzer) throws AnalysisException {
// min/max is not currently supported on sliding windows (i.e. start bound is not
// unbounded).
- if (window != null && isMinMax(fn) &&
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9076: [Bug][Function] fix lag/lead function get invalid data
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9076:
URL: https://github.com/apache/incubator-doris/pull/9076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9076: [Bug][Function] fix lag/lead function get invalid data
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9076:
URL: https://github.com/apache/incubator-doris/pull/9076#issuecomment-1101137663
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9076: [Bug][Function] fix lag/lead function get invalid data
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9076:
URL: https://github.com/apache/incubator-doris/pull/9076#issuecomment-1101137597
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9076: [Bug][Function] fix lag/lead function get invalid data
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #9076:
URL: https://github.com/apache/incubator-doris/pull/9076#discussion_r851913501
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/AnalyticExpr.java:
##########
@@ -478,11 +478,13 @@ public void analyzeImpl(Analyzer analyzer) throws AnalysisException {
// min/max is not currently supported on sliding windows (i.e. start bound is not
// unbounded).
- if (window != null && isMinMax(fn) &&
Review Comment:
add comment here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org