You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (Created) (JIRA)" <ji...@apache.org> on 2011/11/08 21:45:52 UTC
[jira] [Created] (CASSANDRA-3474) SSTableMetadata deserialization
works but looks broken
SSTableMetadata deserialization works but looks broken
------------------------------------------------------
Key: CASSANDRA-3474
URL: https://issues.apache.org/jira/browse/CASSANDRA-3474
Project: Cassandra
Issue Type: Improvement
Components: Core
Affects Versions: 1.0.0
Reporter: Jonathan Ellis
Priority: Minor
Fix For: 1.0.3
This is confusing:
{code}
. if (!descriptor.usesHistogramAndReplayPositionStatsFile)
return deserialize(dis); // deserializes histogram
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3474) SSTableMetadata deserialization
works but looks broken
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146560#comment-13146560 ]
Jonathan Ellis commented on CASSANDRA-3474:
-------------------------------------------
Also: no check is made for descriptor supporting maxTimestamp before reading it. (This is probably the source of some EOF errors I've seen reported on 1.0.x.)
> SSTableMetadata deserialization works but looks broken
> ------------------------------------------------------
>
> Key: CASSANDRA-3474
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3474
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 1.0.3
>
>
> This is confusing:
> {code}
> . if (!descriptor.usesHistogramAndReplayPositionStatsFile)
> return deserialize(dis); // deserializes histogram
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3474) SSTableMetadata deserialization
works but looks broken
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147101#comment-13147101 ]
Sylvain Lebresne commented on CASSANDRA-3474:
---------------------------------------------
The patch needs rebasing but lgtm otherwise.
> SSTableMetadata deserialization works but looks broken
> ------------------------------------------------------
>
> Key: CASSANDRA-3474
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3474
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 1.0.3
>
> Attachments: 3474.txt
>
>
> This is confusing:
> {code}
> . if (!descriptor.usesHistogramAndReplayPositionStatsFile)
> return deserialize(dis); // deserializes histogram
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3474) SSTableMetadata deserialization
works but looks broken
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146555#comment-13146555 ]
Jonathan Ellis commented on CASSANDRA-3474:
-------------------------------------------
(The problem is that usesHistogramAndReplayPositionStatsFile is actually the opposite of what the name implies. It also checks the wrong Descriptor version which is weird. Finally, there's a bunch of duplicated code.)
> SSTableMetadata deserialization works but looks broken
> ------------------------------------------------------
>
> Key: CASSANDRA-3474
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3474
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 1.0.3
>
>
> This is confusing:
> {code}
> . if (!descriptor.usesHistogramAndReplayPositionStatsFile)
> return deserialize(dis); // deserializes histogram
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3474) SSTableMetadata deserialization
works but looks broken
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146566#comment-13146566 ]
Jonathan Ellis commented on CASSANDRA-3474:
-------------------------------------------
Finally: the no-maxtimestamp default was to Long.MAX_VALUE when the correct one is Long.MIN_VALUE. This only mattered if the stats file was missing completely; if it existed but was a version earlier than h it would EOF out as mentioned above.
> SSTableMetadata deserialization works but looks broken
> ------------------------------------------------------
>
> Key: CASSANDRA-3474
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3474
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 1.0.3
>
> Attachments: 3474.txt
>
>
> This is confusing:
> {code}
> . if (!descriptor.usesHistogramAndReplayPositionStatsFile)
> return deserialize(dis); // deserializes histogram
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3474) SSTableMetadata deserialization
works but looks broken
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3474:
--------------------------------------
Attachment: 3474.txt
Patch to fix above.
> SSTableMetadata deserialization works but looks broken
> ------------------------------------------------------
>
> Key: CASSANDRA-3474
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3474
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 1.0.3
>
> Attachments: 3474.txt
>
>
> This is confusing:
> {code}
> . if (!descriptor.usesHistogramAndReplayPositionStatsFile)
> return deserialize(dis); // deserializes histogram
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira