You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2016/06/10 01:05:21 UTC

[jira] [Commented] (HBASE-15974) Create a ReplicationQueuesClientHBaseImpl

    [ https://issues.apache.org/jira/browse/HBASE-15974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323679#comment-15323679 ] 

Hadoop QA commented on HBASE-15974:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 4 new or modified test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s {color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 19s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 11s {color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 49s {color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 51s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 25s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 57s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s {color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s {color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s {color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 1s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 57s {color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 8s {color} | {color:red} hbase-client-jdk1.8.0 with JDK v1.8.0 generated 4 new + 5 unchanged - 0 fixed = 9 total (was 5) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 57s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 3m 0s {color} | {color:red} hbase-client-jdk1.7.0_79 with JDK v1.7.0_79 generated 4 new + 5 unchanged - 0 fixed = 9 total (was 5) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 52s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 49s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 25s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 26m 28s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 20s {color} | {color:red} hbase-client generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s {color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 4m 0s {color} | {color:red} hbase-client-jdk1.7.0_79 with JDK v1.7.0_79 generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 51s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 59s {color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 55s {color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 19s {color} | {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 65m 37s {color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-client |
|  |  Dead store to queues in org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl.getAllQueuesScanner(String)  At ReplicationQueuesHBaseImpl.java:org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl.getAllQueuesScanner(String)  At ReplicationQueuesHBaseImpl.java:[line 251] |
|  |  Dead store to queues in org.apache.hadoop.hbase.replication.ReplicationTableBase.getQueuesBelongingToServer(String)  At ReplicationTableBase.java:org.apache.hadoop.hbase.replication.ReplicationTableBase.getQueuesBelongingToServer(String)  At ReplicationTableBase.java:[line 275] |
|  |  Invocation of toString on rowKey in org.apache.hadoop.hbase.replication.ReplicationTableBase.getLogsInQueue(byte[])  At ReplicationTableBase.java:in org.apache.hadoop.hbase.replication.ReplicationTableBase.getLogsInQueue(byte[])  At ReplicationTableBase.java:[line 231] |
| Failed junit tests | hadoop.hbase.master.cleaner.TestReplicationHFileCleaner |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12809326/HBASE-15974.patch |
| JIRA Issue | HBASE-15974 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
| git revision | master / 6da6bab |
| Default Java | 1.7.0_79 |
| Multi-JDK versions |  /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 |
| findbugs | v3.0.0 |
| javac | hbase-client-jdk1.8.0: https://builds.apache.org/job/PreCommit-HBASE-Build/2169/artifact/patchprocess/diff-compile-javac-hbase-client-jdk1.8.0.txt |
| javac | hbase-client-jdk1.7.0_79: https://builds.apache.org/job/PreCommit-HBASE-Build/2169/artifact/patchprocess/diff-compile-javac-hbase-client-jdk1.7.0_79.txt |
| whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/2169/artifact/patchprocess/whitespace-eol.txt |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/2169/artifact/patchprocess/new-findbugs-hbase-client.html |
| javadoc | hbase-client-jdk1.7.0_79: https://builds.apache.org/job/PreCommit-HBASE-Build/2169/artifact/patchprocess/diff-javadoc-javadoc-hbase-client-jdk1.7.0_79.txt |
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/2169/artifact/patchprocess/patch-unit-hbase-server.txt |
| unit test logs |  https://builds.apache.org/job/PreCommit-HBASE-Build/2169/artifact/patchprocess/patch-unit-hbase-server.txt |
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/2169/testReport/ |
| modules | C: hbase-client hbase-server U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/2169/console |
| Powered by | Apache Yetus 0.2.1   http://yetus.apache.org |


This message was automatically generated.



> Create a ReplicationQueuesClientHBaseImpl
> -----------------------------------------
>
>                 Key: HBASE-15974
>                 URL: https://issues.apache.org/jira/browse/HBASE-15974
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Replication
>            Reporter: Joseph
>            Assignee: Joseph
>         Attachments: HBASE-15974.patch
>
>
> Currently ReplicationQueuesClient utilizes a ZooKeeper implementation ReplicationQueuesClientZkImpl that attempts to read from the ZNode where ReplicationQueuesZkImpl tracked WAL's. So we need to create a HBase implementation for ReplicationQueuesClient.
> The review is posted at https://reviews.apache.org/r/48521/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)