You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/10/06 21:41:44 UTC

Review Request 62818: Removed a redundant equality check for Mount disk source.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62818/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Joseph Wu.


Repository: mesos


Description
-------

Removed a redundant equality check for Mount disk source.


Diffs
-----

  src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246 


Diff: https://reviews.apache.org/r/62818/diff/1/


Testing
-------


Thanks,

Jie Yu


Re: Review Request 62818: Removed a redundant equality check for Mount disk source.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62818/#review187307
-----------------------------------------------------------


Ship it!




LGTM.

- Joseph Wu


On Oct. 6, 2017, 2:41 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62818/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2017, 2:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed a redundant equality check for Mount disk source.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp ea0f3a28b55bc9e6b52bb2215b39a0f323396246 
> 
> 
> Diff: https://reviews.apache.org/r/62818/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jie Yu
> 
>