You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/06 15:57:16 UTC

[GitHub] [arrow] mjunix opened a new pull request #12347: Fix incorrect CPUID flag for AVX detection

mjunix opened a new pull request #12347:
URL: https://github.com/apache/arrow/pull/12347


   (I don't have any experience with this codebase so someone should probably review this before merging.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] cyb70289 commented on a change in pull request #12347: Fix incorrect CPUID flag for AVX detection

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on a change in pull request #12347:
URL: https://github.com/apache/arrow/pull/12347#discussion_r800271068



##########
File path: cpp/src/arrow/util/cpu_info.cc
##########
@@ -288,7 +288,7 @@ bool RetrieveCPUInfo(int64_t* hardware_flags, std::string* model_name,
   if (features_ECX[19]) *hardware_flags |= CpuInfo::SSE4_1;
   if (features_ECX[20]) *hardware_flags |= CpuInfo::SSE4_2;
   if (features_ECX[23]) *hardware_flags |= CpuInfo::POPCNT;
-  if (features_ECX[23]) *hardware_flags |= CpuInfo::AVX;
+  if (features_ECX[28]) *hardware_flags |= CpuInfo::AVX;

Review comment:
       Thanks for this fix. Based on below doc, we did have a typo here.
   https://en.wikipedia.org/wiki/CPUID#EAX=1:_Processor_Info_and_Feature_Bits




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12347: ARROW-15607: [C++] Fix incorrect CPUID flag for AVX detection

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12347:
URL: https://github.com/apache/arrow/pull/12347#issuecomment-1032168055


   Benchmark runs are scheduled for baseline = ee7897a3a44c8fd972544330106c3e7bbae6ba24 and contender = d056829e877cdbbe071ea3fb34bd0b9ad42145e6. d056829e877cdbbe071ea3fb34bd0b9ad42145e6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e8f56b1b42e2424188cdeb1fc03c9d83...a7e25e52ce0d4793b86dfab53c2b18dd/)
   [Finished :arrow_down:0.3% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c16561e825fe4b26b5cad8eded519d54...89473cc90dfa43b79cb193eeed9c714b/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/759f6f115adf4f339690334f8277ffa1...6920a02613044ed799bbc1e6a2c8ad47/)
   [Finished :arrow_down:0.09% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a11a49990b264267a5e7948c9dfbabab...ff3451f691604f10bd9bd7d0deed2af5/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] cyb70289 commented on pull request #12347: Fix incorrect CPUID flag for AVX detection

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #12347:
URL: https://github.com/apache/arrow/pull/12347#issuecomment-1030996235


   @mjunix Will you open a jira for this issue?
   https://arrow.apache.org/docs/developers/contributing.html#report-bugs-and-propose-features


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #12347: Fix incorrect CPUID flag for AVX detection

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12347:
URL: https://github.com/apache/arrow/pull/12347#issuecomment-1030860781


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
   
   Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12347: ARROW-15607: [C++] Fix incorrect CPUID flag for AVX detection

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12347:
URL: https://github.com/apache/arrow/pull/12347#issuecomment-1032168055


   Benchmark runs are scheduled for baseline = ee7897a3a44c8fd972544330106c3e7bbae6ba24 and contender = d056829e877cdbbe071ea3fb34bd0b9ad42145e6. d056829e877cdbbe071ea3fb34bd0b9ad42145e6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e8f56b1b42e2424188cdeb1fc03c9d83...a7e25e52ce0d4793b86dfab53c2b18dd/)
   [Finished :arrow_down:0.3% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c16561e825fe4b26b5cad8eded519d54...89473cc90dfa43b79cb193eeed9c714b/)
   [Finished :arrow_down:0.71% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/759f6f115adf4f339690334f8277ffa1...6920a02613044ed799bbc1e6a2c8ad47/)
   [Finished :arrow_down:0.09% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a11a49990b264267a5e7948c9dfbabab...ff3451f691604f10bd9bd7d0deed2af5/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] cyb70289 closed pull request #12347: ARROW-15607: [C++] Fix incorrect CPUID flag for AVX detection

Posted by GitBox <gi...@apache.org>.
cyb70289 closed pull request #12347:
URL: https://github.com/apache/arrow/pull/12347


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] cyb70289 commented on pull request #12347: ARROW-15607: [C++] Fix incorrect CPUID flag for AVX detection

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #12347:
URL: https://github.com/apache/arrow/pull/12347#issuecomment-1032163339


   Thanks @mjunix! I've created a jira issue and merged this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12347: ARROW-15607: [C++] Fix incorrect CPUID flag for AVX detection

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12347:
URL: https://github.com/apache/arrow/pull/12347#issuecomment-1032168055


   Benchmark runs are scheduled for baseline = ee7897a3a44c8fd972544330106c3e7bbae6ba24 and contender = d056829e877cdbbe071ea3fb34bd0b9ad42145e6. d056829e877cdbbe071ea3fb34bd0b9ad42145e6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e8f56b1b42e2424188cdeb1fc03c9d83...a7e25e52ce0d4793b86dfab53c2b18dd/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c16561e825fe4b26b5cad8eded519d54...89473cc90dfa43b79cb193eeed9c714b/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/759f6f115adf4f339690334f8277ffa1...6920a02613044ed799bbc1e6a2c8ad47/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a11a49990b264267a5e7948c9dfbabab...ff3451f691604f10bd9bd7d0deed2af5/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #12347: ARROW-15607: [C++] Fix incorrect CPUID flag for AVX detection

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12347:
URL: https://github.com/apache/arrow/pull/12347#issuecomment-1032160967






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #12347: ARROW-15607: [C++] Fix incorrect CPUID flag for AVX detection

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12347:
URL: https://github.com/apache/arrow/pull/12347#issuecomment-1032168055


   Benchmark runs are scheduled for baseline = ee7897a3a44c8fd972544330106c3e7bbae6ba24 and contender = d056829e877cdbbe071ea3fb34bd0b9ad42145e6. d056829e877cdbbe071ea3fb34bd0b9ad42145e6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e8f56b1b42e2424188cdeb1fc03c9d83...a7e25e52ce0d4793b86dfab53c2b18dd/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c16561e825fe4b26b5cad8eded519d54...89473cc90dfa43b79cb193eeed9c714b/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/759f6f115adf4f339690334f8277ffa1...6920a02613044ed799bbc1e6a2c8ad47/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a11a49990b264267a5e7948c9dfbabab...ff3451f691604f10bd9bd7d0deed2af5/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12347: ARROW-15607: [C++] Fix incorrect CPUID flag for AVX detection

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12347:
URL: https://github.com/apache/arrow/pull/12347#issuecomment-1032168055


   Benchmark runs are scheduled for baseline = ee7897a3a44c8fd972544330106c3e7bbae6ba24 and contender = d056829e877cdbbe071ea3fb34bd0b9ad42145e6. d056829e877cdbbe071ea3fb34bd0b9ad42145e6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e8f56b1b42e2424188cdeb1fc03c9d83...a7e25e52ce0d4793b86dfab53c2b18dd/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c16561e825fe4b26b5cad8eded519d54...89473cc90dfa43b79cb193eeed9c714b/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/759f6f115adf4f339690334f8277ffa1...6920a02613044ed799bbc1e6a2c8ad47/)
   [Finished :arrow_down:0.09% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a11a49990b264267a5e7948c9dfbabab...ff3451f691604f10bd9bd7d0deed2af5/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org