[incubator-kyuubi] branch master updated: [KYUUBI #2448] Log the engine id when opening Kyuubi connection

[fe...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

feiwang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new eeb8a94f1 [KYUUBI #2448] Log the engine id when opening Kyuubi connection
eeb8a94f1 is described below

commit eeb8a94f126c62bd016f46bc23c509d57f77687c
Author: Fei Wang <fw...@ebay.com>
AuthorDate: Sun Apr 24 00:08:23 2022 +0800

    [KYUUBI #2448] Log the engine id when opening Kyuubi connection
    
    ### _Why are the changes needed?_
    
    Log the engine id when opening Kyuubi connection, it is more user friendly.
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #2448 from turboFei/connection_engine_id.
    
    Closes #2448
    
    f05ffa19 [Fei Wang] log engine id
    
    Authored-by: Fei Wang <fw...@ebay.com>
    Signed-off-by: Fei Wang <fw...@ebay.com>
---
 .../src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala b/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala
index 2d0a710d5..d0b4b865e 100644
--- a/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala
+++ b/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala
@@ -112,7 +112,8 @@ class KyuubiSessionImpl(
             e)
           throw e
       }
-      logSessionInfo(s"Connected to engine [$host:$port] with ${_engineSessionHandle}")
+      logSessionInfo(s"Connected to engine [$host:$port]/[${client.engineId.getOrElse("")}]" +
+        s" with ${_engineSessionHandle}]")
       sessionEvent.openedTime = System.currentTimeMillis()
       sessionEvent.remoteSessionId = _engineSessionHandle.identifier.toString
       _client.engineId.foreach(e => sessionEvent.engineId = e)