[GitHub] [spark] zhengruifeng commented on a diff in pull request #38253: [SPARK-40796][CONNECT][BUILD][WIP] Check the generated python protos in GitHub Actions

[GitBox <gi...@apache.org>]

zhengruifeng commented on code in PR #38253:
URL: https://github.com/apache/spark/pull/38253#discussion_r995420859


##########
connector/connect/dev/generate_protos.sh:
##########
@@ -55,10 +70,13 @@ buf generate --debug -vvv
 for f in `find gen/proto/python -name "*.py*"`; do
   # First fix the imports.
   if [[ $f == *_pb2.py || $f == *_pb2_grpc.py ]]; then
-    sed -i '' -e 's/from spark.connect import/from pyspark.sql.connect.proto import/g' $f

Review Comment:
   `sed -i ''` doesn't work in Linux, so make this change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org