[GitHub] [hudi] satishkotha commented on a change in pull request #3475: [HUDI-1822][RFC-27][WIP] range index support with metadata table

[GitBox <gi...@apache.org>]

satishkotha commented on a change in pull request #3475:
URL: https://github.com/apache/hudi/pull/3475#discussion_r744391803



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java
##########
@@ -671,7 +671,7 @@ public String getBaseFileExtension() {
   }
 
   public boolean requireSortedRecords() {
-    return getBaseFileFormat() == HoodieFileFormat.HFILE;
+    return getBaseFileFormat() == HoodieFileFormat.HFILE || config.requiresSorting();

Review comment:
       @nsivabalan We were initially considering parquet file format as an option of range index. So I added it as a config to support sorting on parquet files in metadata table. Now that we have finalized HFile format (at least for short term), we can probably remove config.  Sorry for delay, I missed your mention. Feel free to ping me on slack if you have any followups




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org