You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nitt10prashant <gi...@git.apache.org> on 2016/05/26 10:54:30 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9389:changing check_string fro...
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/1563
CLOUDSTACK-9389:changing check_string from 3 packets received to 3 re\u2026
test cases were failing due to invalid check_string so changing check_string from "3 packets received" to "3 received" based on ping reply in centos vm.
[root@BPKxDmS ~]# ping -c 3 8.8.8.8
PING 8.8.8.8 (8.8.8.8) 56(84) bytes of data.
64 bytes from 8.8.8.8: icmp_seq=1 ttl=52 time=16.9 ms
64 bytes from 8.8.8.8: icmp_seq=2 ttl=52 time=16.7 ms
64 bytes from 8.8.8.8: icmp_seq=3 ttl=52 time=17.0 ms
\u2014 8.8.8.8 ping statistics \u2014
3 packets transmitted, 3 received, 0% packet loss, time 2020ms
rtt min/avg/max/mdev = 16.720/16.896/17.015/0.196 ms
test results
---------------
Prashants-MacBook-Pro:test_routers_network_ops_L62AAM prashant$ cat results.txt
Test redundant router internals ... === TestName: test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 2 tests in 1003.374s
OK
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nitt10prashant/cloudstack CI
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1563.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1563
----
commit a182376c34b5e59de7a0cd82949480b2b3ed5c94
Author: nitt10prashant <ni...@gmail.com>
Date: 2016-05-26T10:47:51Z
CLOUDSTACK-9389:changing check_string from 3 packets received to 3 received
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222438208
test result
------------
Prashants-MacBook-Pro:test_routers_network_ops_TWUWR8 prashant$ cat results.txt
Test redundant router internals ... === TestName: test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 5 tests in 1752.174s
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1563
@nitt10prashant ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the issue:
https://github.com/apache/cloudstack/pull/1563
@swill just curious to know Which guest OS you are using ? Since Cent OS template is default in ACS i modified test_data for cent OS.
Regx should be consider ?
->I Agree with you, will push changes for regx to make sure it work for both ping pattern .
What do you think? Sorry, I don't mean to be combative here, but this is a good opertunity for us to review the way we handle OS specific test data.
->Yes this should be discussed thoroughly and should be documented properly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test_routers_n...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1563
@swill My MS is running on Rhel6.3 , in script we are doing ssh to guest vm and then trying to ping 8.8.8.8 so ping is dependent on guest template OS , in my case i am using default temple which is CentOS 6.5.
code snippet
ssh_command = "ping -c 3 8.8.8.8"
check_string = "3 received"
result = check_router_command(virtual_machine, nat_rule.ipaddress, ssh_command, check_string, self)
self.assertEqual(
result,
expected,
"Ping to outside world from VM should be successful!"
)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test_routers_n...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1563
Right, of course it is the VM template that matters. Sorry I am not thinking straight right now. I am testing using the Tiny Linux template, so that could be why. When I have a second I will see what the result of `ping -c 8.8.8.8` is in that template. We may want to make what is expected to be a regular expressions. Something like this maybe `3(.*?) received` (not tested), so we can account for the different wording provided by different guest VM templates.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222140055
### CI RESULTS
```
Tests Run: 78
Skipped: 0
Failed: 2
Errors: 4
Duration: 7h 21m 57s
```
**Summary of the problem(s):**
```
ERROR: test suite for <class 'integration.smoke.test_internal_lb.TestInternalLb'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 296, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_IGZRHU/results.txt
```
```
ERROR: test suite for <class 'integration.smoke.test_vpc_vpn.TestRVPCSite2SiteVpn'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 835, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_IGZRHU/results.txt
```
```
ERROR: test suite for <class 'integration.smoke.test_vpc_vpn.TestVpcRemoteAccessVpn'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 293, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_IGZRHU/results.txt
```
```
ERROR: test suite for <class 'integration.smoke.test_vpc_vpn.TestVpcSite2SiteVpn'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 209, in run
self.setUp()
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 292, in setUp
self.setupContext(ancestor)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 315, in setupContext
try_run(context, names)
File "/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, in try_run
return func()
File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 472, in setUpClass
cls.template.download(cls.apiclient)
File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_IGZRHU/results.txt
```
```
FAIL: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 831, in test_01_isolate_network_FW_PF_default_routes_egress_true
"Ping to outside world from VM should be successful!"
AssertionError: Ping to outside world from VM should be successful!
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_IGZRHU/results.txt
```
```
FAIL: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 279, in test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true
"Ping to outside world from VM should be successful!"
AssertionError: Ping to outside world from VM should be successful!
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_IGZRHU/results.txt
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__May_26_2016_18_29_46_OK3MA3:`**
* [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/DeployDataCenter__May_26_2016_18_29_46_OK3MA3/dc_entries.obj)
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/DeployDataCenter__May_26_2016_18_29_46_OK3MA3/failed_plus_exceptions.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/DeployDataCenter__May_26_2016_18_29_46_OK3MA3/runinfo.txt)
**`/tmp/MarvinLogs/test_network_IGZRHU:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/test_network_IGZRHU/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/test_network_IGZRHU/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/test_network_IGZRHU/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_G2CQ7O:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/test_vpc_routers_G2CQ7O/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/test_vpc_routers_G2CQ7O/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/test_vpc_routers_G2CQ7O/runinfo.txt)
Uploads will be available until `2016-07-27 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1563
### ACS CI BVT Run
**Sumarry:**
Build Number 184
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222222559
Again the same problems and they seem related to this PR, so we will need to review this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222104760
Changes LGTM. Now the expected ping response can be configured in test_data based on OS type.
@nitt10prashant Please post the test execution result.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222635435
@koushik-das as you have asked done following
1- moved check_string to test_data.py
2-provided test result
can you review changes .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the issue:
https://github.com/apache/cloudstack/pull/1563
-->I think it is important that the test data does not need to be changed for our automated(ish) CI to show the tests are passing
@swill i think test-data meant to be changed depend on your local environment and every one should have local copy of their own test data .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the issue:
https://github.com/apache/cloudstack/pull/1563
Not needed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222222200
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 2
Errors: 0
Duration: 3h 59m 06s
```
**Summary of the problem(s):**
```
FAIL: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 831, in test_01_isolate_network_FW_PF_default_routes_egress_true
"Ping to outside world from VM should be successful!"
AssertionError: Ping to outside world from VM should be successful!
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_87FU3R/results.txt
```
```
FAIL: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs1/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 279, in test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true
"Ping to outside world from VM should be successful!"
AssertionError: Ping to outside world from VM should be successful!
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_87FU3R/results.txt
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__May_27_2016_15_51_17_6Q3OHL:`**
* [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/DeployDataCenter__May_27_2016_15_51_17_6Q3OHL/dc_entries.obj)
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/DeployDataCenter__May_27_2016_15_51_17_6Q3OHL/failed_plus_exceptions.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/DeployDataCenter__May_27_2016_15_51_17_6Q3OHL/runinfo.txt)
**`/tmp/MarvinLogs/test_network_87FU3R:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/test_network_87FU3R/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/test_network_87FU3R/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/test_network_87FU3R/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_2Y96KN:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/test_vpc_routers_2Y96KN/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/test_vpc_routers_2Y96KN/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1563/tmp/MarvinLogs/test_vpc_routers_2Y96KN/runinfo.txt)
Uploads will be available until `2016-07-27 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1563: CLOUDSTACK-9389:[automation]updating test_rou...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant closed the pull request at:
https://github.com/apache/cloudstack/pull/1563
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222643203
Thanks @nitt10prashant for the making the changes. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222140541
The failures seem relevant. I do have periodic issues with similar tests in my CI env, so I will test this again to be sure there is an issue...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test_routers_n...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1563
@nitt10prashant what is your setup? My management server is running on CentOS7. I suspect the string to search for could change depending on the OS running.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/1563
This assumes that people know how to work with the test data and that they understand that "this random template needs X format and this other one will need Y format". This is too much to ask without guidance, especially as we try to improve the automatability of the testing.
The regex idea is not a perfect solution, but would allow for us to handle more template types with a single entry. Ideally we would be able to specify the expected values for this type of thing in an OS specific way so the tested (and verified) values for each OS can live in the test data. It would probably need a default that is used if the current OS does not have a match.
My main problem with this is that it will, by default, break this test for everyone using bubble to automate their testing. Maybe we leave the old default test value in place, and people who are testing with other OSs can now override manually.
What do you think? Sorry, I don't mean to be combative here, but this is a good opertunity for us to review the way we handle OS specific test data.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222439377
@swill i don't see any issue in my setup , please checktest result
[results.txt](https://github.com/apache/cloudstack/files/289139/results.txt)
[runinfo.txt](https://github.com/apache/cloudstack/files/289140/runinfo.txt)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test_routers_n...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1563
I think it is important that the test data does not need to be changed for our automated(ish) CI to show the tests are passing. Right now because of size and speed to run the tests, a lot of us are using Tiny Linux as the template for testing. I agree it should work for both, but to do that I think we will need to use regex in order to handle more than one expected correct result.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9389:[automation]updating test_routers_n...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1563
@swill Thinking about 3(.*?) received , i have placed check_string in test_data.py , which can be modified depend on guest OS type . I followed cent os ping pattern since most of us use default template.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---