You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by dg...@hyperreal.org on 1998/01/14 01:05:01 UTC
cvs commit: apache/src CHANGES mod_rewrite.c
dgaudet 98/01/13 16:05:01
Modified: . Tag: APACHE_1_2_X STATUS
src Tag: APACHE_1_2_X CHANGES mod_rewrite.c
Log:
fix %3f problem in mod_rewrite
Submitted by: Ralf Engelschall
Reviewed by: Dean Gaudet, Roy Fielding
Revision Changes Path
No revision
No revision
1.1.2.13 +1 -30 apache/Attic/STATUS
Index: STATUS
===================================================================
RCS file: /export/home/cvs/apache/Attic/STATUS,v
retrieving revision 1.1.2.12
retrieving revision 1.1.2.13
diff -u -r1.1.2.12 -r1.1.2.13
--- STATUS 1998/01/14 00:02:52 1.1.2.12
+++ STATUS 1998/01/14 00:04:56 1.1.2.13
@@ -10,6 +10,7 @@
* Mark Bixby's MPE port patch
* more #define wrappers from FreeBSD port
* Dean's backport of the bputc()/chunking bugfix.
+ * Ralf's mod_rewrite bugfix for %3f
Available:
@@ -21,10 +22,6 @@
Alternate solution already in 1.3.
Needs update against new mod_include.
- * Ralf's mod_rewrite bugfix for %3f
- see below
- Status: Ralf +1, Dean +1, Roy +1
-
* Marc's "headers too big" patch, repost it please?
* backport of the netscape header padding fix, it's needed for 255
@@ -37,29 +34,3 @@
* Some fix for the bogus byte ranges bug.
* fix os_escape_path()
-
-Stuff from Ralf:
-
-* The following 1.2.5-adjusted bugfix for mod_rewrite.c
- which fixes the "Location: http://host/bar%3fquery" problem (the "?"
- is escaped but have not!)
-
- Index: mod_rewrite.c
- ===================================================================
- RCS file: /e/apache/REPOS/apache/src/mod_rewrite.c,v
- retrieving revision 1.28.2.3
- diff -u -r1.28.2.3 mod_rewrite.c
- --- mod_rewrite.c 1997/08/17 20:35:49 1.28.2.3
- +++ mod_rewrite.c 1997/10/28 11:53:52
- @@ -1590,6 +1590,7 @@
- }
- rewritelog(r, 2, "[per-dir %s] redirect %s -> %s", perdir, r->filename, newuri);
- r->filename = pstrdup(r->pool, newuri);
- + splitout_queryargs(r, p->flags & RULEFLAG_QSAPPEND);
- r->status = p->forced_responsecode;
- return 1;
- }
-
- For 1.3 this bugfix is different and already replaced by the new patch
- replacing the complete rewriting engine I'll post these days .
-
No revision
No revision
1.286.2.65 +3 -0 apache/src/CHANGES
Index: CHANGES
===================================================================
RCS file: /export/home/cvs/apache/src/CHANGES,v
retrieving revision 1.286.2.64
retrieving revision 1.286.2.65
diff -u -r1.286.2.64 -r1.286.2.65
--- CHANGES 1998/01/14 00:02:55 1.286.2.64
+++ CHANGES 1998/01/14 00:04:58 1.286.2.65
@@ -1,5 +1,8 @@
Changes with Apache 1.2.6
+ *) mod_rewrite would not handle %3f properly in some situations.
+ [Ralf Engelschall]
+
*) Apache could generate improperly chunked HTTP/1.1 responses when
the bputc() or rputc() functions were used by modules (such as
mod_include). [Dean Gaudet]
1.28.2.4 +1 -0 apache/src/mod_rewrite.c
Index: mod_rewrite.c
===================================================================
RCS file: /export/home/cvs/apache/src/mod_rewrite.c,v
retrieving revision 1.28.2.3
retrieving revision 1.28.2.4
diff -u -r1.28.2.3 -r1.28.2.4
--- mod_rewrite.c 1997/08/17 20:35:49 1.28.2.3
+++ mod_rewrite.c 1998/01/14 00:04:59 1.28.2.4
@@ -1590,6 +1590,7 @@
}
rewritelog(r, 2, "[per-dir %s] redirect %s -> %s", perdir, r->filename, newuri);
r->filename = pstrdup(r->pool, newuri);
+ splitout_queryargs(r, p->flags & RULEFLAG_QSAPPEND);
r->status = p->forced_responsecode;
return 1;
}