You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2009/06/02 01:59:07 UTC

[jira] Created: (HADOOP-5953) KosmosFileSystem.isDirectory() should not be deprecated.

KosmosFileSystem.isDirectory() should not be deprecated.
--------------------------------------------------------

                 Key: HADOOP-5953
                 URL: https://issues.apache.org/jira/browse/HADOOP-5953
             Project: Hadoop Core
          Issue Type: Bug
          Components: fs
            Reporter: Tsz Wo (Nicholas), SZE
            Assignee: Tsz Wo (Nicholas), SZE


FileSystem.isDirectory() was un-deprecated by HADOOP-5045.  We should do the same for KosmosFileSystem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5953) KosmosFileSystem.isDirectory() should not be deprecated.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-5953:
-------------------------------------------

    Attachment: 5953_20090601.patch

5953_20090601.patch: un-deprecated isDirectory(..) and isFile(..) in KosmosFileSystem.

> KosmosFileSystem.isDirectory() should not be deprecated.
> --------------------------------------------------------
>
>                 Key: HADOOP-5953
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5953
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 5953_20090601.patch
>
>
> FileSystem.isDirectory() was un-deprecated by HADOOP-5045.  We should do the same for KosmosFileSystem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5953) KosmosFileSystem.isDirectory() should not be deprecated.

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715328#action_12715328 ] 

Suresh Srinivas commented on HADOOP-5953:
-----------------------------------------

+1. Change looks good.

> KosmosFileSystem.isDirectory() should not be deprecated.
> --------------------------------------------------------
>
>                 Key: HADOOP-5953
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5953
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 5953_20090601.patch
>
>
> FileSystem.isDirectory() was un-deprecated by HADOOP-5045.  We should do the same for KosmosFileSystem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5953) KosmosFileSystem.isDirectory() should not be deprecated.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715596#action_12715596 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-5953:
------------------------------------------------

{noformat}
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
{noformat}
The patch removes two @Deprecates annotations.  No new tests added.

> KosmosFileSystem.isDirectory() should not be deprecated.
> --------------------------------------------------------
>
>                 Key: HADOOP-5953
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5953
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 5953_20090601.patch
>
>
> FileSystem.isDirectory() was un-deprecated by HADOOP-5045.  We should do the same for KosmosFileSystem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HADOOP-5953) KosmosFileSystem.isDirectory() should not be deprecated.

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE resolved HADOOP-5953.
--------------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.21.0
     Hadoop Flags: [Reviewed]

I have committed this.

> KosmosFileSystem.isDirectory() should not be deprecated.
> --------------------------------------------------------
>
>                 Key: HADOOP-5953
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5953
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.21.0
>
>         Attachments: 5953_20090601.patch
>
>
> FileSystem.isDirectory() was un-deprecated by HADOOP-5045.  We should do the same for KosmosFileSystem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.