You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/15 23:42:00 UTC
[jira] [Commented] (NIFI-5820) NiFi built with Java 1.8 needs to
run on Java 11
[ https://issues.apache.org/jira/browse/NIFI-5820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688802#comment-16688802 ]
ASF GitHub Bot commented on NIFI-5820:
--------------------------------------
GitHub user jtstorck opened a pull request:
https://github.com/apache/nifi/pull/3174
[WIP] NIFI-5820 NiFi built on Java 1.8 can run on Java 9/10/11
Updated RunNiFi.java to add libs need to run on Java 11 when it is the detected runtime java version and grant access to the necessary module when running on Java 9 or 10
Added dependencies/includes/excludes to nifi-assembly configurations for enabling NiFi to run on Java 11
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jtstorck/nifi NIFI-5820
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3174
----
commit 4859444b6b503a86953d0a6b06be07f081357552
Author: Jeff Storck <jt...@...>
Date: 2018-11-15T23:38:02Z
NIFI-5820 NiFi built on Java 1.8 can run on Java 9/10/11
Updated RunNiFi.java to add libs need to run on Java 11 when it is the detected runtime java version and grant access to the necessary module when running on Java 9 or 10
Added dependencies/includes/excludes to nifi-assembly configurations for enabling NiFi to run on Java 11
----
> NiFi built with Java 1.8 needs to run on Java 11
> ------------------------------------------------
>
> Key: NIFI-5820
> URL: https://issues.apache.org/jira/browse/NIFI-5820
> Project: Apache NiFi
> Issue Type: Sub-task
> Reporter: Jeff Storck
> Assignee: Jeff Storck
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)