You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/05 05:17:49 UTC
[GitHub] [helix] narendly opened a new pull request #865: Add
rerunFailingTestsCount config to surefire-plugin
narendly opened a new pull request #865: Add rerunFailingTestsCount config to surefire-plugin
URL: https://github.com/apache/helix/pull/865
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fixes #864
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
It was observed that if build fails (if there is a test failure), then not all of the test goals are executed. There are currently two goals: default-test (single ZK) and multi-zk. If default-test has any test failures, we won't ever see multi-zk get executed, and this is a problem because we don't get to run the test suite in a multi-zk setup.
This config change is a workaround for this - we allow failing tests to be retried up to 3 times to make them pass. If they still fail, we will consider them as flaky tests and have to fix them moving forward.
### Tests
- [x] The following tests are written for this issue:
build without tests
```
INFO] Apache Helix ....................................... SUCCESS [ 1.193 s]
[INFO] Apache Helix :: Metrics Common ..................... SUCCESS [ 3.385 s]
[INFO] Apache Helix :: Metadata Store Directory Common .... SUCCESS [ 2.906 s]
[INFO] Apache Helix :: ZooKeeper API ...................... SUCCESS [ 6.400 s]
[INFO] Apache Helix :: Helix Common ....................... SUCCESS [ 3.813 s]
[INFO] Apache Helix :: Core ............................... SUCCESS [01:00 min]
[INFO] Apache Helix :: Admin Webapp ....................... SUCCESS [ 7.829 s]
[INFO] Apache Helix :: Restful Interface .................. SUCCESS [ 13.334 s]
[INFO] Apache Helix :: HelixAgent ......................... SUCCESS [ 3.985 s]
[INFO] Apache Helix :: Recipes ............................ SUCCESS [ 0.036 s]
[INFO] Apache Helix :: Recipes :: Rabbitmq Consumer Group . SUCCESS [ 0.794 s]
[INFO] Apache Helix :: Recipes :: Rsync Replicated File Store SUCCESS [ 0.852 s]
[INFO] Apache Helix :: Recipes :: distributed lock manager SUCCESS [ 0.783 s]
[INFO] Apache Helix :: Recipes :: distributed task execution SUCCESS [ 0.857 s]
[INFO] Apache Helix :: Recipes :: service discovery ....... SUCCESS [ 0.809 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:48 min
[INFO] Finished at: 2020-03-04T21:02:45-08:00
[INFO] ------------------------------------------------------------------------
```
- [ ] The following is the result of the "mvn test" command on the appropriate module:
(Copy & paste the result of "mvn test")
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [x] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on issue #865: Add
rerunFailingTestsCount config to surefire-plugin
Posted by GitBox <gi...@apache.org>.
narendly commented on issue #865: Add rerunFailingTestsCount config to surefire-plugin
URL: https://github.com/apache/helix/pull/865#issuecomment-595573612
This PR is ready to be merged, approved by @alirezazamani
It was observed that if build fails (if there is a test failure), then not all of the test goals are executed. There are currently two goals: default-test (single ZK) and multi-zk. If default-test has any test failures, we won't ever see multi-zk get executed, and this is a problem because we don't get to run the test suite in a multi-zk setup.
This config change is a workaround for this - we allow failing tests to be retried up to 3 times to make them pass. If they still fail, we will consider them as flaky tests and have to fix them moving forward.
This PR also address minor comments and fixes a test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly merged pull request #865: Add
rerunFailingTestsCount config to surefire-plugin
Posted by GitBox <gi...@apache.org>.
narendly merged pull request #865: Add rerunFailingTestsCount config to surefire-plugin
URL: https://github.com/apache/helix/pull/865
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org