[Impala-ASF-CR] IMPALA-8330: Impala shell config file should support flag names

["Fredy Wijaya (Code Review)" <ge...@cloudera.org>]

Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12823 )

Change subject: IMPALA-8330: Impala shell config file should support flag names
......................................................................

IMPALA-8330: Impala shell config file should support flag names

This patch updates the file format in Impala shell config file to accept
both short and long flag names in addition to optparse's dest names
(variable names to store flag values) for better user experience because
dest names are internal to Impala shell.

Format:
[impala]
flag_name=flag_value

Example:
[impala]
; This is long flag.
query=select 1
; This is short flag.
Q=DEFAULT_FILE_FORMAT=parquet
; Flags can be repeated with ,
var=msg1=hello,var=msg2=world
; The old format using internal variable name is still supported for
; backward compatibility.
keyval=msg3=foo,keyval=msg4=bar

Testing:
- Ran all E2E shell tests on Python 2.6 and 2.7.

Change-Id: Ic43603c1b538af08fddcab1b2c1f6ad1af1a6cb9
---
M shell/impala_shell.py
M shell/option_parser.py
M tests/shell/good_impalarc
M tests/shell/test_shell_commandline.py
4 files changed, 44 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/12823/6
-- 
To view, visit http://gerrit.cloudera.org:8080/12823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic43603c1b538af08fddcab1b2c1f6ad1af1a6cb9
Gerrit-Change-Number: 12823
Gerrit-PatchSet: 6
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>