You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Bill Ricky <mh...@gmail.com> on 2020/10/07 18:01:20 UTC
Review Request 72939: RANGER-3027: Improve response time for GET API
service/xusers/users
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72939/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-3027
https://issues.apache.org/jira/browse/RANGER-3027
Repository: ranger
Description
-------
RANGER-3027: Improve response time for GET API service/xusers/users
Diffs
-----
security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java 1e41e708a
security-admin/src/main/java/org/apache/ranger/db/XXPortalUserDao.java d383cf596
security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 0464e7b6e
security-admin/src/main/java/org/apache/ranger/service/XUserService.java adb8e6004
security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 9cdc14ebf
security-admin/src/main/java/org/apache/ranger/view/VXUser.java 96f6468f7
security-admin/src/main/resources/META-INF/jpa_named_queries.xml 7d9e145fe
Diff: https://reviews.apache.org/r/72939/diff/1/
Testing
-------
done
Thanks,
Bill Ricky
Re: Review Request 72939: RANGER-3027: Improve response time for GET API service/xusers/users
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72939/#review224846
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java
Lines 204 (patched)
<https://reviews.apache.org/r/72939/#comment313725>
Per description in https://issues.apache.org/jira/browse/RANGER-3929, most databases have a limit of 1000 entries for the list used in "IN" clause. Please review the impact of such limit here.
security-admin/src/main/java/org/apache/ranger/view/VXUser.java
Lines 329 (patched)
<https://reviews.apache.org/r/72939/#comment313724>
hashCode() - is not defined in base classes of VXUser. This call here would result in executing Object.hashCode(), which may not be the intent here. Please review and update.
- Madhan Neethiraj
On Oct. 29, 2022, 10:53 a.m., Bill Ricky wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72939/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2022, 10:53 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-3027
> https://issues.apache.org/jira/browse/RANGER-3027
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-3027: Improve response time for GET API service/xusers/users
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java 76cdd93f5
> security-admin/src/main/java/org/apache/ranger/db/XXPortalUserDao.java 1787eeae6
> security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 99bea26f3
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java d7c011ca3
> security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 25fec3dd4
> security-admin/src/main/java/org/apache/ranger/view/VXUser.java 59375c42a
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml 85c8b6213
>
>
> Diff: https://reviews.apache.org/r/72939/diff/5/
>
>
> Testing
> -------
>
> done
>
>
> File Attachments
> ----------------
>
> 0001-RANGER-3027-Improve-response-time-for-GET-API-servic.patch
> https://reviews.apache.org/media/uploaded/files/2022/10/29/88fd4c1a-32cf-4c2a-9b64-0e64471d39bf__0001-RANGER-3027-Improve-response-time-for-GET-API-servic.patch
>
>
> Thanks,
>
> Bill Ricky
>
>
Re: Review Request 72939: RANGER-3027: Improve response time for GET API service/xusers/users
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72939/#review224844
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java
Lines 187 (patched)
<https://reviews.apache.org/r/72939/#comment313723>
The new methods XGroupUserDao.findByLoginIdList() and XGroupUserDao.findByIdList() are not used. Please review and remove.
security-admin/src/main/java/org/apache/ranger/service/XUserService.java
Lines 365 (patched)
<https://reviews.apache.org/r/72939/#comment313721>
Consider avoiding ArrayList creation by updating findByLoginIdList() parameter type to from List<> to Collection<>.
security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java
Lines 132 (patched)
<https://reviews.apache.org/r/72939/#comment313722>
Given addedByUser and updatedByUser are likely to have duplicates, consider collecting them into a Set<>, instead of List<>. Also, consider updating findByIdList() to receive a Collection<>, instead of List<>.
- Madhan Neethiraj
On Oct. 29, 2022, 10:53 a.m., Bill Ricky wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72939/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2022, 10:53 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-3027
> https://issues.apache.org/jira/browse/RANGER-3027
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-3027: Improve response time for GET API service/xusers/users
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java 76cdd93f5
> security-admin/src/main/java/org/apache/ranger/db/XXPortalUserDao.java 1787eeae6
> security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 99bea26f3
> security-admin/src/main/java/org/apache/ranger/service/XUserService.java d7c011ca3
> security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 25fec3dd4
> security-admin/src/main/java/org/apache/ranger/view/VXUser.java 59375c42a
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml 85c8b6213
>
>
> Diff: https://reviews.apache.org/r/72939/diff/5/
>
>
> Testing
> -------
>
> done
>
>
> File Attachments
> ----------------
>
> 0001-RANGER-3027-Improve-response-time-for-GET-API-servic.patch
> https://reviews.apache.org/media/uploaded/files/2022/10/29/88fd4c1a-32cf-4c2a-9b64-0e64471d39bf__0001-RANGER-3027-Improve-response-time-for-GET-API-servic.patch
>
>
> Thanks,
>
> Bill Ricky
>
>
Re: Review Request 72939: RANGER-3027: Improve response time for GET API service/xusers/users
Posted by Bill Ricky <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72939/
-----------------------------------------------------------
(Updated 十月 29, 2022, 10:53 a.m.)
Review request for ranger.
Bugs: RANGER-3027
https://issues.apache.org/jira/browse/RANGER-3027
Repository: ranger
Description
-------
RANGER-3027: Improve response time for GET API service/xusers/users
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java 76cdd93f5
security-admin/src/main/java/org/apache/ranger/db/XXPortalUserDao.java 1787eeae6
security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 99bea26f3
security-admin/src/main/java/org/apache/ranger/service/XUserService.java d7c011ca3
security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 25fec3dd4
security-admin/src/main/java/org/apache/ranger/view/VXUser.java 59375c42a
security-admin/src/main/resources/META-INF/jpa_named_queries.xml 85c8b6213
Diff: https://reviews.apache.org/r/72939/diff/5/
Changes: https://reviews.apache.org/r/72939/diff/4-5/
Testing
-------
done
File Attachments (updated)
----------------
0001-RANGER-3027-Improve-response-time-for-GET-API-servic.patch
https://reviews.apache.org/media/uploaded/files/2022/10/29/88fd4c1a-32cf-4c2a-9b64-0e64471d39bf__0001-RANGER-3027-Improve-response-time-for-GET-API-servic.patch
Thanks,
Bill Ricky
Re: Review Request 72939: RANGER-3027: Improve response time for GET API service/xusers/users
Posted by Bill Ricky <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72939/
-----------------------------------------------------------
(Updated 十月 29, 2022, 10:41 a.m.)
Review request for ranger.
Bugs: RANGER-3027
https://issues.apache.org/jira/browse/RANGER-3027
Repository: ranger
Description
-------
RANGER-3027: Improve response time for GET API service/xusers/users
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java 76cdd93f5
security-admin/src/main/java/org/apache/ranger/db/XXPortalUserDao.java 1787eeae6
security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 99bea26f3
security-admin/src/main/java/org/apache/ranger/service/XUserService.java d7c011ca3
security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 25fec3dd4
security-admin/src/main/java/org/apache/ranger/view/VXUser.java 59375c42a
security-admin/src/main/resources/META-INF/jpa_named_queries.xml 85c8b6213
Diff: https://reviews.apache.org/r/72939/diff/4/
Changes: https://reviews.apache.org/r/72939/diff/3-4/
Testing
-------
done
File Attachments (updated)
----------------
0001-RANGER-3027-Improve-response-time-for-GET-API-servic.patch
https://reviews.apache.org/media/uploaded/files/2022/10/29/a7f059cb-0176-46f9-bd09-f6cb5030c3ea__0001-RANGER-3027-Improve-response-time-for-GET-API-servic.patch
0001-RANGER-3027-Improve-response-time-for-GET-API-servic.patch
https://reviews.apache.org/media/uploaded/files/2022/10/29/88fd4c1a-32cf-4c2a-9b64-0e64471d39bf__0001-RANGER-3027-Improve-response-time-for-GET-API-servic.patch
Thanks,
Bill Ricky
Re: Review Request 72939: RANGER-3027: Improve response time for GET API service/xusers/users
Posted by Bill Ricky <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72939/
-----------------------------------------------------------
(Updated 十月 29, 2022, 9:36 a.m.)
Review request for ranger.
Bugs: RANGER-3027
https://issues.apache.org/jira/browse/RANGER-3027
Repository: ranger
Description
-------
RANGER-3027: Improve response time for GET API service/xusers/users
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java 76cdd93f5
security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 99bea26f3
security-admin/src/main/java/org/apache/ranger/service/XUserService.java d7c011ca3
security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 25fec3dd4
security-admin/src/main/java/org/apache/ranger/view/VXUser.java 59375c42a
security-admin/src/main/resources/META-INF/jpa_named_queries.xml 85c8b6213
Diff: https://reviews.apache.org/r/72939/diff/3/
Changes: https://reviews.apache.org/r/72939/diff/2-3/
Testing
-------
done
File Attachments (updated)
----------------
0001-RANGER-3027-Improve-response-time-for-GET-API-servic.patch
https://reviews.apache.org/media/uploaded/files/2022/10/29/a7f059cb-0176-46f9-bd09-f6cb5030c3ea__0001-RANGER-3027-Improve-response-time-for-GET-API-servic.patch
Thanks,
Bill Ricky
Re: Review Request 72939: RANGER-3027: Improve response time for GET
API service/xusers/users
Posted by Bill Ricky <mh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72939/
-----------------------------------------------------------
(Updated 十月 12, 2020, 9:47 a.m.)
Review request for ranger.
Bugs: RANGER-3027
https://issues.apache.org/jira/browse/RANGER-3027
Repository: ranger
Description
-------
RANGER-3027: Improve response time for GET API service/xusers/users
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java 1fb692128
security-admin/src/main/java/org/apache/ranger/db/XXPortalUserDao.java d383cf596
security-admin/src/main/java/org/apache/ranger/entity/XXUser.java 0464e7b6e
security-admin/src/main/java/org/apache/ranger/service/XUserService.java adb8e6004
security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java 9cdc14ebf
security-admin/src/main/java/org/apache/ranger/view/VXUser.java 96f6468f7
security-admin/src/main/resources/META-INF/jpa_named_queries.xml a8f581849
Diff: https://reviews.apache.org/r/72939/diff/2/
Changes: https://reviews.apache.org/r/72939/diff/1-2/
Testing
-------
done
Thanks,
Bill Ricky