[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #21213: [fix][broker] Fix lookup heartbeat and sla namespace bundle when using extensible load manager

["Demogorgon314 (via GitHub)" <gi...@apache.org>]

Demogorgon314 commented on code in PR #21213:
URL: https://github.com/apache/pulsar/pull/21213#discussion_r1333833687


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -135,7 +135,7 @@ public class NamespaceService implements AutoCloseable {
     public static final Pattern SLA_NAMESPACE_PATTERN = Pattern.compile(SLA_NAMESPACE_PROPERTY + "/[^/]+/([^:]+:\\d+)");
     public static final String HEARTBEAT_NAMESPACE_FMT = "pulsar/%s/%s";
     public static final String HEARTBEAT_NAMESPACE_FMT_V2 = "pulsar/%s";
-    public static final String SLA_NAMESPACE_FMT = SLA_NAMESPACE_PROPERTY + "/%s/%s:%s";
+    public static final String SLA_NAMESPACE_FMT = SLA_NAMESPACE_PROPERTY + "/%s/%s";

Review Comment:
   Change the format will not break compatibility



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org