You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Ittay Dror (JIRA)" <ji...@apache.org> on 2008/12/10 13:58:44 UTC
[jira] Created: (BUILDR-225) ArchiveTask#merge, not according to
doc
ArchiveTask#merge, not according to doc
---------------------------------------
Key: BUILDR-225
URL: https://issues.apache.org/jira/browse/BUILDR-225
Project: Buildr
Issue Type: Bug
Components: Packaging
Affects Versions: 1.3.2
Reporter: Ittay Dror
Fix For: 1.3.4
The doc says
# Returns an object that supports two methods: include and exclude. You can use these methods to merge
# only specific files. For example:
# zip(..).merge('src.zip').include('module1/*')
but the implementation is:
source.entries.reject { |entry| entry.directory? }.each do |entry|
if @includes.any? { |pattern| File.fnmatch(pattern, entry.name, File::FNM_PATHNAME) } &&
!@excludes.any? { |pattern| File.fnmatch(pattern, entry.name, File::FNM_PATHNAME) }
so it doesn't check directories, only files. so if the zip has module1/src/Foo.java, the pattern 'module1/*' will not match and the file will not be included
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-225) ArchiveTask#merge, not according to
doc
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886216#action_12886216 ]
Hudson commented on BUILDR-225:
-------------------------------
Integrated in Buildr-ci-build #53 (See [http://hudson.zones.apache.org/hudson/job/Buildr-ci-build/53/])
fix for BUILDR-225 ArchiveTask#merge, not according to doc
> ArchiveTask#merge, not according to doc
> ---------------------------------------
>
> Key: BUILDR-225
> URL: https://issues.apache.org/jira/browse/BUILDR-225
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Fix For: 1.4.2
>
>
> The doc says
> # Returns an object that supports two methods: include and exclude. You can use these methods to merge
> # only specific files. For example:
> # zip(..).merge('src.zip').include('module1/*')
> but the implementation is:
> source.entries.reject { |entry| entry.directory? }.each do |entry|
> if @includes.any? { |pattern| File.fnmatch(pattern, entry.name, File::FNM_PATHNAME) } &&
> !@excludes.any? { |pattern| File.fnmatch(pattern, entry.name, File::FNM_PATHNAME) }
> so it doesn't check directories, only files. so if the zip has module1/src/Foo.java, the pattern 'module1/*' will not match and the file will not be included
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-225) ArchiveTask#merge, not according to
doc
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme resolved BUILDR-225.
-----------------------------------
Resolution: Fixed
Fixed some time ago. I added a spec.
18:54:08~/w/buildr>svn ci CHANGELOG spec -m "fix for BUILDR-225 ArchiveTask#merge, not according to doc"
Sending CHANGELOG
Sending spec/packaging/archive_spec.rb
Transmitting file data ..
Committed revision 961555.
> ArchiveTask#merge, not according to doc
> ---------------------------------------
>
> Key: BUILDR-225
> URL: https://issues.apache.org/jira/browse/BUILDR-225
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Fix For: 1.4.2
>
>
> The doc says
> # Returns an object that supports two methods: include and exclude. You can use these methods to merge
> # only specific files. For example:
> # zip(..).merge('src.zip').include('module1/*')
> but the implementation is:
> source.entries.reject { |entry| entry.directory? }.each do |entry|
> if @includes.any? { |pattern| File.fnmatch(pattern, entry.name, File::FNM_PATHNAME) } &&
> !@excludes.any? { |pattern| File.fnmatch(pattern, entry.name, File::FNM_PATHNAME) }
> so it doesn't check directories, only files. so if the zip has module1/src/Foo.java, the pattern 'module1/*' will not match and the file will not be included
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-225) ArchiveTask#merge, not according to
doc
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme updated BUILDR-225:
----------------------------------
Fix Version/s: 1.4.2
Targeting 1.4.2. It should be fixed already.
> ArchiveTask#merge, not according to doc
> ---------------------------------------
>
> Key: BUILDR-225
> URL: https://issues.apache.org/jira/browse/BUILDR-225
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Fix For: 1.4.2
>
>
> The doc says
> # Returns an object that supports two methods: include and exclude. You can use these methods to merge
> # only specific files. For example:
> # zip(..).merge('src.zip').include('module1/*')
> but the implementation is:
> source.entries.reject { |entry| entry.directory? }.each do |entry|
> if @includes.any? { |pattern| File.fnmatch(pattern, entry.name, File::FNM_PATHNAME) } &&
> !@excludes.any? { |pattern| File.fnmatch(pattern, entry.name, File::FNM_PATHNAME) }
> so it doesn't check directories, only files. so if the zip has module1/src/Foo.java, the pattern 'module1/*' will not match and the file will not be included
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-225) ArchiveTask#merge, not according to
doc
Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655191#action_12655191 ]
Ittay Dror commented on BUILDR-225:
-----------------------------------
also, it looks like using the include method above does not behave as ArchiveTask#include, in that the full path of the entry is included in the archive, not just the base name. it would be nice if Merge#include would have the same spec as ArchiveTask#include
> ArchiveTask#merge, not according to doc
> ---------------------------------------
>
> Key: BUILDR-225
> URL: https://issues.apache.org/jira/browse/BUILDR-225
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Fix For: 1.3.4
>
>
> The doc says
> # Returns an object that supports two methods: include and exclude. You can use these methods to merge
> # only specific files. For example:
> # zip(..).merge('src.zip').include('module1/*')
> but the implementation is:
> source.entries.reject { |entry| entry.directory? }.each do |entry|
> if @includes.any? { |pattern| File.fnmatch(pattern, entry.name, File::FNM_PATHNAME) } &&
> !@excludes.any? { |pattern| File.fnmatch(pattern, entry.name, File::FNM_PATHNAME) }
> so it doesn't check directories, only files. so if the zip has module1/src/Foo.java, the pattern 'module1/*' will not match and the file will not be included
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-225) ArchiveTask#merge, not according to
doc
Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681166#action_12681166 ]
Assaf Arkin commented on BUILDR-225:
------------------------------------
Possibly duplicated by BUILDR-263.
> ArchiveTask#merge, not according to doc
> ---------------------------------------
>
> Key: BUILDR-225
> URL: https://issues.apache.org/jira/browse/BUILDR-225
> Project: Buildr
> Issue Type: Bug
> Components: Packaging
> Affects Versions: 1.3.2
> Reporter: Ittay Dror
> Fix For: 1.3.4
>
>
> The doc says
> # Returns an object that supports two methods: include and exclude. You can use these methods to merge
> # only specific files. For example:
> # zip(..).merge('src.zip').include('module1/*')
> but the implementation is:
> source.entries.reject { |entry| entry.directory? }.each do |entry|
> if @includes.any? { |pattern| File.fnmatch(pattern, entry.name, File::FNM_PATHNAME) } &&
> !@excludes.any? { |pattern| File.fnmatch(pattern, entry.name, File::FNM_PATHNAME) }
> so it doesn't check directories, only files. so if the zip has module1/src/Foo.java, the pattern 'module1/*' will not match and the file will not be included
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.